Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-click word selection picks up the RPROMPT from the previous line because word wrapping is hard #17165

Closed
DHowett opened this issue Apr 30, 2024 · 2 comments · Fixed by #17170
Closed

Double-click word selection picks up the RPROMPT from the previous line because word wrapping is hard #17165

DHowett opened this issue Apr 30, 2024 · 2 comments · Fixed by #17170
Assignees
@DHowett
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@DHowett
Copy link
Member

DHowett commented Apr 30, 2024

Discussed this with Leonard a while ago
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 30, 2024
@DHowett DHowett added this to the Terminal v1.21 milestone Apr 30, 2024
DHowett added a commit that referenced this issue May 1, 2024
@DHowett
Take wrapping into account when expanding wordwise selections
97c3180 
Closes #17165
@DHowett DHowett mentioned this issue May 1, 2024
Merged
@carlos-zamora carlos-zamora added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 1, 2024
@lhecker
Copy link
Member

lhecker commented May 1, 2024

Is this redundant with #17077?

@DHowett
Copy link
Member Author

DHowett commented May 1, 2024

Wow it actually is! Great find

@DHowett DHowett mentioned this issue May 1, 2024
Closed
DHowett added a commit that referenced this issue May 2, 2024
@DHowett
Take wrapping into account when expanding wordwise selections (#17170)
6cda679 
Closes #17165
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 2, 2024
DHowett added a commit that referenced this issue May 6, 2024
@DHowett
Take wrapping into account when expanding wordwise selections (#17170)
345d266 
Closes #17165

(cherry picked from commit 6cda679)
Service-Card-Id: 92471634
Service-Version: 1.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Take wrapping into account when expanding wordwise selections microsoft/terminal
3 participants
@DHowett @lhecker @carlos-zamora