Take wrapping into account when expanding wordwise selections #17170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
lhecker
reviewed
May 1, 2024
Comment on lines
+1445
to
+1449
| // Prevent wrapping to the previous line if the selection begins on whitespace | ||
| if (isControlChar) | ||
| { | ||
| break; | ||
| } |
There was a problem hiding this comment.
...but should we? If I print a b and it force-wraps in the middle, shouldn't I be able to select all 4 spaces with a double click?
There was a problem hiding this comment.
Eh, I didn't want to revisit too many of the decisions from the previous code.
But also, this is what prevents us from selecting the entire text buffer when you double-click an empty space lmao
lhecker
approved these changes
May 1, 2024
carlos-zamora
approved these changes
May 1, 2024
| VERIFY_IS_TRUE(_buffer->GetRowByOffset(0).WasWrapForced()); | ||
| VERIFY_IS_FALSE(_buffer->GetRowByOffset(1).WasWrapForced()); | ||
| // GH#780 See the comment in WriteLinesToBuffer | ||
| // VERIFY_IS_FALSE(_buffer->GetRowByOffset(2).WasWrapForced()); |
There was a problem hiding this comment.
Suggested change
| // VERIFY_IS_FALSE(_buffer->GetRowByOffset(2).WasWrapForced()); |
dead code?
There was a problem hiding this comment.
No, pertinent to the comment above it
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
zadjii-msft
approved these changes
May 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
DHowett
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17165