Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure MinMaxCloseControl supports FullScreen & Tablet Mode #2001

Open
zadjii-msft opened this issue Jul 17, 2019 · 2 comments
Open

Make sure MinMaxCloseControl supports FullScreen & Tablet Mode #2001

zadjii-msft opened this issue Jul 17, 2019 · 2 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Some thoughts about the Min/Max/Close buttons, and supporting FullScreen or Tablet Mode

Some properties to consider for this TitlebarControl. This could be also be useful for the Settings UI, if it is presented in a window.

  • CanMaximise
  • CanMinimise
  • CanRestore

Which would hide those buttons if you wanted to make a settings screen which only shows a close button. Also consider how these TitleBar Controls will handle FullScreen/Tablet Mode

image
Full Screen

Screenshot (17)
Tablet Mode

Originally posted by @mdtauk in #1948 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 17, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 17, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 17, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 17, 2019
Closed
29 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 20, 2019
@bitcrazed bitcrazed mentioned this issue Aug 29, 2019
Closed
29 tasks
@cinnamon-msft cinnamon-msft added Priority-3 A description (P3) v1-Scrubbed Issue-Bug It either shouldn't be doing this or needs an investigation. Help Wanted We encourage anyone to jump in on these. and removed Issue-Task It's a feature request, but it doesn't really need a major design. labels Jan 23, 2020
@AnuthaDev
Copy link
Contributor

@zadjii-msft I would like to work on it. I believe this shall be sufficient to support tablet mode?

@zadjii-msft
Copy link
Member Author

@AnuthaDev absolutely, go for it! If @oldnewthing wrote it, then I'm sure it'll work ☺️

@AnuthaDev AnuthaDev mentioned this issue Jun 24, 2020
Closed
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jun 24, 2020
@AnuthaDev AnuthaDev mentioned this issue Oct 1, 2020
Closed
6 tasks
@ghost ghost removed the In-PR This issue has a related PR label Dec 17, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
5 participants
@DHowett @DHowett-MSFT @zadjii-msft @AnuthaDev @cinnamon-msft