Enable dragging with the entire titlebar #1948

zadjii-msft · 2019-07-12T20:54:10Z

Summary of the Pull Request

If a picture is worth 1000 words, then this is ~~15000 words/second~~ like 18000 words (getting a gif below 10MB was harder than I thought)

References

This is a bunch of the work in #1625 and #1375.

PR Checklist

Closes Use tab-bar/title bar for dragging window around #564

Detailed Description of the Pull Request / Additional comments

This is done with a major change to the NonClientIslandWindow, and the MinMaxControl. I've introduced a new XAML control, the TitlebarControl. The TitlebarControl consists of three parts - Content, Drag Area, and MinMaxControl. The MinMaxControl is now owned by the TitlebarControl, and it does pretty much nothing on it's own. All the hwnd handling has moved up to the TitlebarControl. The MinMaxControl now exists simply as a control with caption buttons.

Instead of the App owning the MinMaxControl, and the titlebar existing as part of the TerminalPage, the TitlebarControl is now owned by the NonClientIslandWindow. The NonClientIslandWindow will initialize it's own UI consisting of a titlebar row and a content row. It'll place a TitlebarControl instance in its titlebar row. It'll also ask the App for content to place in both the client area and the titlebar. When the app is resized, or the titlebar content is resized, the NonClientIslandWindow will update its drag area. The NonClientIslandWindow can also communicate directly with the TitlebarControl, without needing to go through the App to do so. In the future, This should make future windowing-related bugs easier to fix.

TODOs

There's definitely a bug with the bottom margin. A single pixel of your accent color will appear at the bottom of the window. With different MARGINs passed to DwmExtendframIntoClientArea, the amount changes. This regressed between 1905852 and 96c5da2. I want to track this down before we check this in.
- I was able to fix this. We need to not paint the entirety of the root window. As long as it's not all painted, then the border won't be drawn. Click "details" to see my ramblings as I debugged this.

Definitely also regressed after ~~60a444c~~ ~~7b8cf10~~ ~~b9cc819~~ ~~0219781~~ 02e8389 (wait there's only f4e02d8 between those two??)
Oh no, it's broken in master. Must've regressed in f4e02d8, thank god I have that branch locally still.
It's fine in 9040940, which was the last commit in that PR before merging into master. I'll bisect from there to f4e02d8, we'll see where this regressed
- 122f0de: ✔ (Just the TerminalPage changes)
- 122f0de + 5fd4191: ✔ (TerminalPage + Most of the NC painting but not the whole titlebar thing)
- Okay, so 9040940, where I paint the entire titlebar, is what broke it. That's definitely the commit that breaks it.
- 9040940 + 122f0de: ❌ (Fix the NC painting, paint the entire titlebar + TerminalPage)
- 9040940 + 60a444c: ❌ Well this was surprising
This is actually related to how GDI blends with the nonclient area. @DHowett-MSFT was seeing this previously when trying to paint our caption buttons himself. You won't see this bug in light mode, but in dark mode, where the color is #000000, the window frame bleeds through entirely. For example, I have a bright cyan accent color. If I change the backgroundColor to #ff00000, then the single pixel at the bottom will appear almost white:

This should probably wait for @cinnamon-msft's Style the button and tab view background to match the titlebar #1934, so that the UI is more complete. Merging will be painful.
I'm self-blocking this till Refactor TerminalApp and Add Tests for Xaml Content #1164 gets in. Merging will be a pain.

Don't do anything in NCPAINT. If you do, you have to do everything. But the whole point of DwmExtendFrameIntoClientArea is to let you paint the NC area in your normal paint. So just do that dummy. * This doesn't transition across monitors. * This has a window style change I think is wrong. * I'm not sure the margins change is important.

…high DPI

I'm not entirely sure why. But if we only update the titlebar drag region when that actually changes, it's a _lot_ smoother. I'm not super happy with the duplicated work in _UpdateDragRegion and OnSize, but checking this in in case I can't figure that out.

…ie/f/newtab-btn-float-left

…tton * Make the new tab button transparent, to see how that looks * Make sure the TabView doesn't push the MMC off the window

* The TitlebarControl is owned by the NCIW. It consists of a Content, DragBar, and MMCControl. * The App instatntiates a TabRowControl at runtime, and either places it in the UI (for tabs below titlebar) or hangs on to it, and gives it to the NCIW when the NCIW creates its UI. * When the NCIW is created, it creates a grid with two rows, one for the titlebar and one for the app content. * The MMCControl is only responsible for Min Max Close now, and is closer to the window implementation. * The drag bar takes up all the space from the right of the TabRow to the left of the MMC * Things that **DON'T** work: - When you add tabs, the drag bar doesn't update it's size. It only updates OnSize - The MMCControl's Min and Max buttons don't seem to work anymore. - They should probably just expose their OnMinimizeClick and OnMaximizeClick events for the Titlebar to handle minimizing and maximizing. - The drag bar is Magenta (#ff00ff) currently. - I'm not _sure_ we need a TabRowControl. We could probably get away with removing it from the UI tree, I was just being dumb before.

I forgot to plumb the window handle through

…ie/f/newtab-btn-float-left # Conflicts: # src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

…-btn-float-left # Conflicts: # src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

src/cascadia/TerminalApp/App.cpp

src/cascadia/TerminalApp/App.h

DHowett-MSFT · 2019-07-12T21:53:53Z

src/cascadia/TerminalApp/App.h

@@ -53,10 +54,11 @@ namespace winrt::TerminalApp::implementation
        // (which is a root when the tabs are in the titlebar.)
        Windows::UI::Xaml::Controls::Control _root{ nullptr };
        Microsoft::UI::Xaml::Controls::TabView _tabView{ nullptr };
-        Windows::UI::Xaml::Controls::Grid _tabRow{ nullptr };
+
+        TerminalApp::TabRowControl _tabRow{ nullptr };


this was not necessary any longer, yes?

technically yes, the TabRowControl isn't totally necessary, but I was inclined to keep it, to keep each piece more atomic. If you feel strongly, I can change it back

src/cascadia/TerminalApp/MinMaxCloseControl.cpp

DHowett-MSFT · 2019-07-12T22:02:30Z

src/cascadia/TerminalApp/TitlebarControl.cpp

+
+    Windows::UI::Xaml::UIElement TitlebarControl::Content()
+    {
+        return ContentRoot().Children().Size() > 0 ? ContentRoot().Children().GetAt(0) : nullptr;


this is technically something you should use a control template and a template binding for.

so that people can do <TitleBar>Whatever</TitleBar> and it will put Whatever in the Content

That's certainly the direction I was going with this, but I wanted to try and split that into a different task - this one's already getting hefty. I can file a follow-up issue, yea?

src/cascadia/TerminalApp/TitlebarControl.cpp

This reverts commit e038b5d.

…-btn-float-left # Conflicts: # src/cascadia/TerminalApp/TerminalApp.vcxproj

Co-Authored-By: Michael Niksa <miniksa@microsoft.com>

DHowett-MSFT

I like it. A lot.

DHowett-MSFT · 2019-07-16T23:53:56Z

src/cascadia/TerminalApp/TitlebarControl.xaml

+        <ColumnDefinition Width="Auto"/>
+    </Grid.ColumnDefinitions>
+
+    <Grid x:Name="ContentRoot" Grid.Column="0" />


Try out a ContentPresenter. Its sole job is to present content; perhaps it'll help you not have to interact with Children 😄

DHowett-MSFT · 2019-07-16T23:55:45Z

src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

+    // calling. We know that our content is a Grid, so we don't need to worry
+    // about this.
+    const auto fwe = content.try_as<winrt::Windows::UI::Xaml::FrameworkElement>();
+    if (fwe)


Suggested change

if (fwe)

if (const auto fwe = ...)

mdtauk · 2019-07-17T00:12:14Z

Some thoughts about the Min/Max/Close buttons, and supporting FullScreen or Tablet Mode

Some properties to consider for this TitlebarControl. This could be also be useful for the Settings UI, if it is presented in a window.

CanMaximise
CanMinimise
CanRestore

Which would hide those buttons if you wanted to make a settings screen which only shows a close button. Also consider how these TitleBar Controls will handle FullScreen/Tablet Mode

Full Screen

Tablet Mode

miniksa

…-btn-float-left

wait _what_

zadjii-msft · 2019-07-18T19:24:09Z

/azp run

azure-pipelines · 2019-07-18T19:24:17Z

Azure Pipelines successfully started running 1 pipeline(s).

…-btn-float-left

zadjii-msft · 2019-07-18T21:17:17Z

/azp run

azure-pipelines · 2019-07-18T21:17:26Z

Azure Pipelines successfully started running 1 pipeline(s).

@miniksa

* This definitely works for getting shadow, pointy corners back Don't do anything in NCPAINT. If you do, you have to do everything. But the whole point of DwmExtendFrameIntoClientArea is to let you paint the NC area in your normal paint. So just do that dummy. * This doesn't transition across monitors. * This has a window style change I think is wrong. * I'm not sure the margins change is important. * The window style was _not_ important * Still getting a black xaml islands area (the HRGN) when we switch to high DPI * I don't know if this affects anything. * heyo this works. I'm not entirely sure why. But if we only update the titlebar drag region when that actually changes, it's a _lot_ smoother. I'm not super happy with the duplicated work in _UpdateDragRegion and OnSize, but checking this in in case I can't figure that out. * Add more comments and cleanup * Try making the button RightCustomContent * * Make the MinMaxClose's drag bar's min size the same as a caption button * Make the new tab button transparent, to see how that looks * Make sure the TabView doesn't push the MMC off the window * Create a TitlebarControl * The TitlebarControl is owned by the NCIW. It consists of a Content, DragBar, and MMCControl. * The App instatntiates a TabRowControl at runtime, and either places it in the UI (for tabs below titlebar) or hangs on to it, and gives it to the NCIW when the NCIW creates its UI. * When the NCIW is created, it creates a grid with two rows, one for the titlebar and one for the app content. * The MMCControl is only responsible for Min Max Close now, and is closer to the window implementation. * The drag bar takes up all the space from the right of the TabRow to the left of the MMC * Things that **DON'T** work: - When you add tabs, the drag bar doesn't update it's size. It only updates OnSize - The MMCControl's Min and Max buttons don't seem to work anymore. - They should probably just expose their OnMinimizeClick and OnMaximizeClick events for the Titlebar to handle minimizing and maximizing. - The drag bar is Magenta (#ff00ff) currently. - I'm not _sure_ we need a TabRowControl. We could probably get away with removing it from the UI tree, I was just being dumb before. * Fix the MMC buttons not working I forgot to plumb the window handle through * Make the titlebar less magenta * Resize the drag region as we add/remove tabs * Move the actual MMC handling to the TitlebarControl * Some PR nits, fix the titlebar painting on maximize * Put the TabRow in our XAML * Remove dead code in preparation for review * Horrifyingly try Gdi Plus as a solution, that is _wrong_ though * Revert "Horrifyingly try Gdi Plus as a solution, that is _wrong_ though" This reverts commit e038b5d. * This fixes the bottom border but breaks the titlebar painting * Fix the NC bottom border * A bunch of the more minor PR nits * Add a MinimizeClick event to the MMCControl This works for Minimize. This is what I wanted to do originally. * Add events for _all_ of the buttons, not just the Minimize btn * Change hoe setting the titlebar content works Now the app triggers a callcack on the host to set the content, instead of the host querying the app. * Move the tab row to the bottom of it's available space * Fix the theme reloading * PR nits from @miniksa * Update src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp Co-Authored-By: Michael Niksa <miniksa@microsoft.com> * This needed to be fixed, was missed in other PR nits * runformat wait _what_ * Does this fix the CI build?

ghost · 2019-08-03T01:49:37Z

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

zadjii-msft added 19 commits July 9, 2019 09:11

The window style was _not_ important

0bc9969

Still getting a black xaml islands area (the HRGN) when we switch to …

bf239b6

…high DPI

I don't know if this affects anything.

22e1023

heyo this works.

aad9f56

I'm not entirely sure why. But if we only update the titlebar drag region when that actually changes, it's a _lot_ smoother. I'm not super happy with the duplicated work in _UpdateDragRegion and OnSize, but checking this in in case I can't figure that out.

Add more comments and cleanup

5fd4191

Merge branch 'dev/migrie/f/1625-less-round-more-shadow' into dev/migr…

b02d9eb

…ie/f/newtab-btn-float-left

Try making the button RightCustomContent

5c50804

* Make the MinMaxClose's drag bar's min size the same as a caption bu…

10bcf6e

…tton * Make the new tab button transparent, to see how that looks * Make sure the TabView doesn't push the MMC off the window

Fix the MMC buttons not working

cf939cc

I forgot to plumb the window handle through

Make the titlebar less magenta

a6ad655

Resize the drag region as we add/remove tabs

ac1f20b

Move the actual MMC handling to the TitlebarControl

1905852

Some PR nits, fix the titlebar painting on maximize

9040940

Merge branch 'dev/migrie/f/1625-less-round-more-shadow' into dev/migr…

96c5da2

…ie/f/newtab-btn-float-left # Conflicts: # src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

Put the TabRow in our XAML

2636b11

Merge remote-tracking branch 'origin/master' into dev/migrie/f/newtab…

dcdbdca

…-btn-float-left # Conflicts: # src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

Remove dead code in preparation for review

69a78d4

zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 12, 2019

zadjii-msft changed the title ~~Enable fragging with the entire titlebar~~ Enable dragging with the entire titlebar Jul 12, 2019

cinnamon-msft mentioned this pull request Jul 12, 2019

Style the button and tab view background to match the titlebar #1934

Merged

5 tasks

DHowett-MSFT suggested changes Jul 12, 2019

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 12, 2019

DHowett-MSFT mentioned this pull request Jul 14, 2019

MEGA THREAD: Design still subject to change, UI is pretty okay though #1375

Closed

29 tasks

zadjii-msft added 3 commits July 15, 2019 08:41

Horrifyingly try Gdi Plus as a solution, that is _wrong_ though

e038b5d

Revert "Horrifyingly try Gdi Plus as a solution, that is _wrong_ though"

faef5c7

This reverts commit e038b5d.

This fixes the bottom border but breaks the titlebar painting

83dc600

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 15, 2019

zadjii-msft mentioned this pull request Jul 16, 2019

Add a setting to enable the using the Accent Color for the titlebar #1963

Closed

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 16, 2019

zadjii-msft mentioned this pull request Jul 16, 2019

TitlebarControl should be a Template #1988

Open

zadjii-msft and others added 3 commits July 16, 2019 11:15

Merge remote-tracking branch 'origin/master' into dev/migrie/f/newtab…

8e057ea

…-btn-float-left # Conflicts: # src/cascadia/TerminalApp/TerminalApp.vcxproj

PR nits from @miniksa

c4a398b

Update src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

bf534c6

Co-Authored-By: Michael Niksa <miniksa@microsoft.com>

DHowett-MSFT approved these changes Jul 16, 2019

View reviewed changes

This was referenced Jul 17, 2019

Make sure MinMaxCloseControl supports FullScreen & Tablet Mode #2001

Open

Build a TerminalAppLib and TerminalAppDll separately #2002

Closed

miniksa approved these changes Jul 17, 2019

View reviewed changes

zadjii-msft added 3 commits July 17, 2019 16:05

Merge remote-tracking branch 'origin/master' into dev/migrie/f/newtab…

f0dc01e

…-btn-float-left

This needed to be fixed, was missed in other PR nits

6e41097

runformat

744a27f

wait _what_

zadjii-msft added 2 commits July 18, 2019 15:01

Merge remote-tracking branch 'origin/master' into dev/migrie/f/newtab…

e2fde7a

…-btn-float-left

Does this fix the CI build?

dc5b18a

zadjii-msft merged commit 8ffff8e into master Jul 18, 2019

zadjii-msft mentioned this pull request Jul 19, 2019

Tabs covered by '+v' buttons #2030

Closed

DJackman123 mentioned this pull request Jul 19, 2019

Run as Administrator no longer works #2042

Closed

mcpiroman mentioned this pull request Jul 22, 2019

Terminal crashes when the window width is too small #2045

Closed

JushBJJ mentioned this pull request Jul 22, 2019

Reduce tab area so it is easier to drag the window #2062

Closed

DHowett-MSFT deleted the dev/migrie/f/newtab-btn-float-left branch July 23, 2019 23:25

ghost mentioned this pull request Aug 3, 2019

Use tab-bar/title bar for dragging window around #564

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable dragging with the entire titlebar #1948

Enable dragging with the entire titlebar #1948

zadjii-msft commented Jul 12, 2019 •

edited

Loading

DHowett-MSFT Jul 12, 2019

zadjii-msft Jul 15, 2019

DHowett-MSFT Jul 12, 2019

DHowett-MSFT Jul 12, 2019

zadjii-msft Jul 15, 2019

DHowett-MSFT left a comment

DHowett-MSFT Jul 16, 2019

DHowett-MSFT Jul 16, 2019

mdtauk commented Jul 17, 2019 •

edited

Loading

miniksa left a comment

zadjii-msft commented Jul 18, 2019

azure-pipelines bot commented Jul 18, 2019

zadjii-msft commented Jul 18, 2019

azure-pipelines bot commented Jul 18, 2019

ghost commented Aug 3, 2019

Enable dragging with the entire titlebar #1948

Enable dragging with the entire titlebar #1948

Conversation

zadjii-msft commented Jul 12, 2019 • edited Loading

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

TODOs

DHowett-MSFT Jul 12, 2019

Choose a reason for hiding this comment

zadjii-msft Jul 15, 2019

Choose a reason for hiding this comment

DHowett-MSFT Jul 12, 2019

Choose a reason for hiding this comment

DHowett-MSFT Jul 12, 2019

Choose a reason for hiding this comment

zadjii-msft Jul 15, 2019

Choose a reason for hiding this comment

DHowett-MSFT left a comment

Choose a reason for hiding this comment

DHowett-MSFT Jul 16, 2019

Choose a reason for hiding this comment

DHowett-MSFT Jul 16, 2019

Choose a reason for hiding this comment

mdtauk commented Jul 17, 2019 • edited Loading

miniksa left a comment

Choose a reason for hiding this comment

zadjii-msft commented Jul 18, 2019

azure-pipelines bot commented Jul 18, 2019

zadjii-msft commented Jul 18, 2019

azure-pipelines bot commented Jul 18, 2019

ghost commented Aug 3, 2019

zadjii-msft commented Jul 12, 2019 •

edited

Loading

mdtauk commented Jul 17, 2019 •

edited

Loading