-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a configuration object for focused vs unfocused state #3062
Comments
Yanking Triage -- this is a neat feature, but it does require a little bit of thinkin' about. |
@coupez There's actually a bunch of other threads that have covered that discussion, but this isn't one of them. This mostly tracks controlling the appearance of an active pane vs inactive panes, when there are many panes in the same tab. For discussion on how acrylic works, see: #2326, #1886, #1747, #1546, #1505, #1099, #593, #3336, #2763, #2698, #3497 |
Sure it's "just" a cosmetic thing, but isn't the new Term also about a cosmetic refresh? So for me it is totally annoying having it going totally black when not focused. Looks pretty bad und totally uneccessary. |
not even a hack for the Acrylic to be present when the focus is lost? |
This comment has been minimized.
This comment has been minimized.
This isn't the thread to discuss whether acrylic should be enabled when the window is focused or not. There's like 11 threads I linked above that are better suited for that discussion. There's also #7158 which is tracking investigating if unfocused acrylic is possible in the Terminal. I'd ask that we re-direct this discussion to that thread, thanks. |
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Spec for #3062 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [x] Is documentation * [ ] Schema updated. * [x] I work here <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Read the spec
This pull request adds an appearance configuration object to our settings model and app lib, allowing the control to be rendered differently depending on its state, and then uses it to add support for an "unfocused" appearance that the terminal will use when it's not in focus. To accomplish this, we isolated the appearance-related settings from Profile (into AppearanceConfig) and TerminalSettings (into the IControlAppearance and ICoreAppearance interfaces). A bunch of work was done to make inheritance work. The unfocused appearance inherits from the focused one _for that profile_. This is important: If you define a defaults.unfocusedAppearance, it will apply all of defaults' settings to any leaf profile when a terminal in that profile is out of focus. Specified in #8345 Closes #3062 Closes #2316
🎉This issue was addressed in #8392, which has now been successfully released as Handy links: |
🎉This issue was addressed in #8392, which has now been successfully released as Handy links: |
Follow up from #994.
Originally suggested by @cdmihai in #994
Taking that idea and running with it, what if each profile could specify an "unfocused" state that's used when it loses focus?
Presumably,
backgroundImage
settings would also be fine in that block.Things I wouldn't want to enable in this block:
padding
,fontFace
,fontSize
.[1]: Technically, with split panes, they could have an unfocused control that could still have an acrylic BG, as long as the window remains focused.
I'm realizing now that this is strictly a superset of #2316, and will also resolve that one. I maybe could have just used that thread originally.
26 Mar 2020: #5130 brought up the good point that this should also include enabling the cursor to still be On, even when the control isn't focused
The text was updated successfully, but these errors were encountered: