Maximize and minimize window buttons incorrect rendering

[JekRock]

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable):0.8.10091.0

Steps to reproduce

1. Minimize the Windows Terminal window
2. Open enough terminal tabs to fill tabs space without tabs being resized.
3. Maximize the Windows Terminal window with the window maximize button.
4. Minimize the Windows Terminal window with the window minimize button.
5. Get an incorrect rendering of the minimize and maximize buttons.

On step 2 you will probably need to play with the Windows Terminal window size to reproduce the issue. For some window sizes, it renders normally and for some not. If you add too many terminal tabs the issue is not reproducible.

Expected behavior

Normal rendering of the window minimize and maximize buttons after minimizing the Windows Terminal window

Actual behavior

See attached screenshots.

[zadjii-msft]

from #4310:

@DHowett-MSFT

What is your display scaling set to?

@JekRock

I've stumbled upon the same issue. It's described here
I have 2 displays. One with 100% scaling and one with 125%. The issue is reproducible on both displays

[DHowett-MSFT]

It looks like we're not placing the drag cutout in the right place. Might be part of #1625.

[DHowett-MSFT]

v0.10 justification: it's experience-breaking.

[DHowett-MSFT]

I'm going to call this a "bug class" and merge it with /dup #4166 - "we are not sizing the drag bar properly all the time"

[ghost]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

[beviu]

@zadjii-msft

This was marked duplicate of #4166 and #4166 was closed but I can still reproduce this bug on master (cc35c83) with your fix on my 100% dpi displays so I think it's a separate issue (maybe it was not a dup and it has nothing to do with DPI!).

steps:

1. launch terminal, keep its original size (but note that my config has 0 padding, see below)
2. resize it to remove one text column
3. add 4 tabs
4. maximize
5. minimize
6. try to hover min/max controls

my config

// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation

{
    "$schema": "https://aka.ms/terminal-profiles-schema",

    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",

    "profiles":
    [
        {
            // Make changes here to the powershell.exe profile
            "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
            "name": "Windows PowerShell",
            "commandline": "powershell.exe",
            "hidden": false,
            "padding": "0"
        },
        {
            // Make changes here to the cmd.exe profile
            "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "name": "cmd",
            "commandline": "cmd.exe",
            "hidden": false,
            "padding": "0"
        }
    ],

    // Add custom color schemes to this array
    "schemes": [],

    // Add any keybinding overrides to this array.
    // To unbind a default keybinding, set the command to "unbound"
    "keybindings": [],

    "showTabsInTitlebar": true
}

(On the GIF i was actually running my branch to get rid of HRGN so that's why the controls didn't completely disappear like in the image from the issue but you can ignore this)

[zadjii-msft]

Okay yea I can re-activate this one and make sure this gets fixed too.

Thanks for the diligence @greg904!

---

EDIT: Wow I got this to happen immediately. My repro was way easier:
<notes to self>

1. Use the "mode" profile I currently have as default, and "initialCols": 80. The "mode" bit probably isn't relevant.
2. Open a second tab
3. Maximize
4. Restore

and that's it.