Resize the drag bar on WM_DISPLAYCHANGE
#4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msftbot make sure @DHowett signs off |
ghost
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
DHowett-MSFT
approved these changes
Mar 6, 2020
carlos-zamora
approved these changes
Mar 6, 2020
3 tasks
DHowett-MSFT
pushed a commit
that referenced
this pull request
Mar 9, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 9, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 10, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 10, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Pretty straightforward. When we get a
WM_DISPLAYCHANGE, that means the display's DPI changed. When that happens, resize the drag bar, so that it'll reflect the new scaling.References
I'm doing this to unblock #4778
PR Checklist
Validation Steps Performed
Man I've changed the DPI of my displays so many times in the last 30 minutes. I draged the window across a bunch of DPI boundaries too.