Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyFormatting Keybinding Arg for Copy #5262

Closed
carlos-zamora opened this issue Apr 6, 2020 · 2 comments · Fixed by #6004
Closed

copyFormatting Keybinding Arg for Copy #5262

carlos-zamora opened this issue Apr 6, 2020 · 2 comments · Fixed by #6004
Assignees
@carlos-zamora
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.x

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

A copy keybinding should have a keybinding arg that allows you to copy the formatting of a selection.

More details on how this feature should be implemented are included here:
@carlos-zamora carlos-zamora added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 6, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 6, 2020
@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Apr 6, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 6, 2020
@carlos-zamora carlos-zamora mentioned this issue Apr 6, 2020
Merged
1 task
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 7, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.x milestone Apr 7, 2020
@DHowett-MSFT
Copy link
Contributor

Triaged into 1.x.

ghost pushed a commit that referenced this issue Apr 9, 2020
@carlos-zamora
Add 'copyFormatting' global setting (#5263)
c55d9cd 
## Summary of the Pull Request
Implements `copyFormatting` as a global setting. When enabled, formatting such as font and foreground/background colors are copied to the clipboard on _all_ copy operations.

Also updates the schema and docs.

## References
#5212 - Spec for Formatted Copying
#4191 - Setting to enable/disable formatted copy

This feature will also have an impact on these yet-to-be-implemented features:
- #5262 - copyFormatting Keybinding Arg for Copy
- #1553 - Pointer Bindings


## PR Checklist
* [X] Closes #4191

## Detailed Description of the Pull Request / Additional comments
We already check if the hstring passed into the clipboard is empty before setting it. So the majority of the changes are actually just adding the global setting in.

## Validation Steps Performed
| `copyFormatting` | Mouse Copy | Keyboard Copy |
|--|--|--|
| not set (`false`) | ✔ | ✔ |
| `true` | ✔ | ✔ |
| `false` | ✔ | ✔ |
@carlos-zamora carlos-zamora mentioned this issue Apr 9, 2020
Merged
ghost pushed a commit that referenced this issue Apr 9, 2020
@carlos-zamora
Add 'copyFormatting' global setting (#5299)
ea1bb2e 
## Summary of the Pull Request
Implements `copyFormatting` as a global setting. When enabled, formatting such as font and foreground/background colors are copied to the clipboard on _all_ copy operations.

Also updates the schema and docs.

## References
#5212 - Spec for Formatted Copying
#4191 - Setting to enable/disable formatted copy

#5263 - PR prematurely merged without approval of #5212 

This feature will also have an impact on these yet-to-be-implemented features:
- #5262 - copyFormatting Keybinding Arg for Copy
- #1553 - Pointer Bindings
- #4191 - add array support for `copyFormatting`


## Detailed Description of the Pull Request
We already check if the hstring passed into the clipboard is empty before setting it. So the majority of the changes are actually just adding the global setting in.

## Validation Steps Performed
| `copyFormatting` | Mouse Copy | Keyboard Copy |
|--|--|--|
| not set (`false`) | ✔ | ✔ |
| `true` | ✔ | ✔ |
| `false` | ✔ | ✔ |
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@carlos-zamora carlos-zamora mentioned this issue May 19, 2020
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label May 19, 2020
@carlos-zamora carlos-zamora mentioned this issue May 21, 2020
Open
25 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Jun 24, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 15, 2020
DHowett pushed a commit that referenced this issue Aug 15, 2020
@carlos-zamora
Add copyFormatting keybinding arg and array support (#6004)
24b8c13 
Adds array support for the existing `copyFormatting` global setting.
This allows users to define which formats they would specifically like
to be copied.

A boolean value is still accepted and is translated to the following:
- `false` --> `"none"` or `[]`
- `true` --> `"all"` or `["html", "rtf"]`

This also adds `copyFormatting` as a keybinding arg for `copy`. As with
the global setting, a boolean value and array value is accepted.

CopyFormat is a WinRT enum where each accepted format is a flag.
Currently accepted formats include `html`, and `rtf`. A boolean value is
accepted and converted. `true` is a conjunction of all the formats.
`false` only includes plain text.

For the global setting, `null` is not accepted. We already have a
default value from before so no worries there.

For the keybinding arg, `null` (the default value) means that we just do
what the global arg says to do. Overall, the `copyFormatting` keybinding
arg is an override of the global setting **when using that keybinding**.

References #5212 - Spec for formatted copying
References #2690 - disable html copy

Validated behavior with every combination of values below:
- `copyFormatting` global: { `true`, `false`, `[]`, `["html"]` }
- `copyFormatting` copy arg:
  { `null`, `true`, `false`, `[]`, `[, "html"]`}

Closes #4191
Closes #5262
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 15, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #6004, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Add copyFormatting keybinding arg and array support microsoft/terminal
2 participants
@carlos-zamora @DHowett-MSFT