Add 'copyFormatting' global setting

[carlos-zamora]

Summary of the Pull Request

Implements copyFormatting as a global setting. When enabled, formatting such as font and foreground/background colors are copied to the clipboard on all copy operations.

Also updates the schema and docs.

References

#5212 - Spec for Formatted Copying
#4191 - Setting to enable/disable formatted copy

#5263 - PR prematurely merged without approval of #5212

This feature will also have an impact on these yet-to-be-implemented features:

• copyFormatting Keybinding Arg for Copy #5262 - copyFormatting Keybinding Arg for Copy
• Feature Request: Mouse/Touch/Pointer Bindings (like middle-click paste, right-click context menu, etc.) #1553 - Pointer Bindings
• Add setting to select which formats of copy to perform (text, rtf or html) #4191 - add array support for copyFormatting

Detailed Description of the Pull Request

We already check if the hstring passed into the clipboard is empty before setting it. So the majority of the changes are actually just adding the global setting in.

Validation Steps Performed

copyFormatting	Mouse Copy	Keyboard Copy
not set (false)	✔	✔
true	✔	✔
false	✔	✔

[DHowett-MSFT]

~ ~ BLOCKING UNTIL THE SPEC MERGES ~ ~

[mcpiroman]

Well, don't wanna complain and all, but technically this only closes #2690, not #4191 (actually the former happens to be already closed, because you apparently decided to not implement it back then).

This also looks like the implementation of option 1b from the spec at #5212, and what i was really into was the option 2b - it is what was originally requested (to split html from rtf) and is flexible so you can e.g. create separate commands for plain copy and html copy, which is common in other terminals, and is what some guy proposed in the original issue. I don't know your plans about that though, just throwing my opinion.

[DHowett-MSFT]

To be fair, this is called out in the discussion section.

---

Question: Should this actually close #4191?
Yes: the sentiment behind this issue was to disable/enable formatted copy
No: the proposal was to copy specific formats
For now, I've assumed yes, but still wanted to point it out

[carlos-zamora]

Well, don't wanna complain and all, but technically this only closes #2690, not #4191 (actually the former happens to be already closed, because you apparently decided to not implement it back then).

This also looks like the implementation of option 1b from the spec at #5212, and what i was really into was the option 2b - it is what was originally requested (to split html from rtf) and is flexible so you can e.g. create separate commands for plain copy and html copy, which is common in other terminals, and is what some guy proposed in the original issue. I don't know your plans about that though, just throwing my opinion.

Yeah. The spec now says that #4191 will be implemented later. So you're right. Updating the PR header now

[zadjii-msft]

Wait I already signed off on this

[DHowett-MSFT]

@msftbot merge this in 1 minute

[ghost]

Hello @DHowett-MSFT!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Thu, 09 Apr 2020 23:32:13 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".