Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow console allocation policies that are finer-grained than the PE image subsystem #7335

Closed
2 of 5 tasks
DHowett opened this issue Aug 18, 2020 · 0 comments · Fixed by #7337
Closed
2 of 5 tasks

Allow console allocation policies that are finer-grained than the PE image subsystem #7335

DHowett opened this issue Aug 18, 2020 · 0 comments · Fixed by #7337
Assignees
@DHowett
Labels
Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. In-PR This issue has a related PR Issue-Scenario Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.
Milestone
Backlog

Comments

@DHowett
Copy link
Member

DHowett commented Aug 18, 2020 •
edited
Loading

Due to the design of the console subsystem on Windows as it has existed
since Windows 95, every application that is stamped with the
IMAGE_SUBSYSTEM_WINDOWS_CUI subsystem in its PE header will be
allocated a console by kernel32 (conclnt, the console client library,
handles this.)

Any application that is stamped IMAGE_SUBSYSTEM_WINDOWS_GUI will not
automatically be allocated a console.

We need something finer-grained than that.

This scenario workitem includes:

  • Creating the new fusion manifest entry
  • Adding support for the fusion manifest entry to conclnt
  • Any APIs that must be added (e.g. AllocConsoleEx) to support this new policy
  • All testing for any new APIs and fusion manifest fields
  • All public facing documentation for any new APIs and fusion manifest fields

MSFT:28455640
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 18, 2020
@DHowett DHowett added Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Scenario Product-Meta The product is the management of the products. labels Aug 18, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 18, 2020
@DHowett DHowett added this to the 21H1 milestone Aug 18, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 18, 2020
DHowett added a commit that referenced this issue Aug 18, 2020
@DHowett
Add a spec for #7335, "console allocation policy"
4ae3783
@DHowett DHowett mentioned this issue Aug 18, 2020
Merged
@miniksa miniksa mentioned this issue Aug 26, 2020
Merged
4 tasks
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Aug 29, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Mar 25, 2021
Open
@zadjii-msft zadjii-msft modified the milestones: Windows vNext, Backlog Jan 4, 2022
@miniksa miniksa removed their assignment Mar 31, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 12, 2023
Closed
@lhecker lhecker mentioned this issue Oct 19, 2023
Closed
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Feb 7, 2024
DHowett added a commit that referenced this issue Feb 7, 2024
@DHowett
Add a spec for #7335, "console allocation policy" (#7337)
71c35cf 
This is a specification for a way to customize console allocations.
The new manifest type `consoleAllocationPolicy` and the new
`AllocConsoleWithOptions` API were already added to the console
client library internally.

Closes #7335
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. In-PR This issue has a related PR Issue-Scenario Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add a spec for #7335, "console allocation policy" microsoft/terminal
3 participants
@DHowett @miniksa @zadjii-msft