Default Terminal Spec #7414

miniksa · 2020-08-26T18:13:57Z

→Doc Link←

Defines the proposed operation of the default terminal feature.

References

Spec for Windows Terminal Process Model 2.0 #7240/Scenario: Windows Terminal 2.0 Process Model Improvements #5000 - Process model, these features are inter-related
Ctrl + Z reopens closed tab #6270/Feature Request - Implement Settings UI #1564 - Settings UI, some of this may have to be specified on the settings UI
Add a spec for #7335, "console allocation policy" #7337/Allow console allocation policies that are finer-grained than the PE image subsystem #7335 - Console Allocation Policy, the requests of command-line apps wanting a hidden window could impact this (or that)

PR Checklist

Specifies Change Windows OS to support default terminal [defterm] #492
I work here.
Is literally documentation.
Am core contributor.

doc/specs/#492 - Default Terminal/spec.md

miniksa · 2020-08-26T18:19:03Z

doc/specs/#492 - Default Terminal/spec.md

+
+## Potential Issues
+
+[comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted.


I think I covered a lot of these in-line above but I could restate briefly or talk about how they cross with other specs going on right now.

Meh, I always thought the "Capabilities" header didn't make any sense. If there are other concerns, I usually stick them here.

I'd think the whole hidden console window / "SW_SHOW" thing that Dustin mentioned in #7337 should probably get a callout here

doc/specs/#492 - Default Terminal/spec.md

miniksa · 2020-08-26T22:19:45Z

https://docs.microsoft.com/en-us/windows/uwp/launch-resume/how-to-create-an-extension

zadjii-msft

Hokay, so obviously if the baby comes and I'm still on block, feel free to dismiss me. Gotta let github know what the last commit I reviewed was.

I think that this has a lot of great fundamentals. I'm mostly concerned with a few of the specifics:

The security of the delegation console
how the delegation console is actually set - does the Terminal set that up? Does the user need to?
What the exact interface we're expecting 3rd party developers to implement is

doc/specs/#492 - Default Terminal/spec.md

zadjii-msft · 2020-08-28T14:21:49Z

doc/specs/#492 - Default Terminal/spec.md

+
+## Potential Issues
+
+[comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted.


Meh, I always thought the "Capabilities" header didn't make any sense. If there are other concerns, I usually stick them here.

I'd think the whole hidden console window / "SW_SHOW" thing that Dustin mentioned in #7337 should probably get a callout here

miniksa · 2020-08-31T21:53:10Z

Prototype/draft code: https://github.com/microsoft/terminal/tree/dev/miniksa/default

sylveon · 2020-09-13T21:59:42Z

What happens if a GUI app calls AllocConsole?

DHowett · 2020-09-13T22:22:27Z

@sylveon as prototyped, it’ll open in Terminal. That’s a worthwhile thing to call out!

- Implements the default application behavior and handoff mechanisms between console and terminal. The inbox portion is done already. This adds the ability for our OpenConsole.exe to accept the incoming server connection from the Windows OS, stand up a PTY session, start the Windows Terminal as a listener for an incoming connection, and then send it the incoming PTY connection for it to launch a tab. - The tab is launched with default settings at the moment. - You must configure the default application using the `conhost.exe` propsheet or with the registry keys. Finishing the setting inside Windows Terminal will be a todo after this is complete. The OS Settings panel work to surface this setting is a dependency delivered by another team and you will not see it here. ## Validation Steps Performed - [x] Manual adjust of registry keys to the delegation conhost/terminal behavior - [x] Adjustment of the delegation options with the propsheet - [x] Launching things from the run box manually and watching them show in Terminal - [x] Launching things from shortcuts and watching them show in the Terminal Documentation on how it works will be a TODO post completion in #9462 References #7414 - Default Terminal spec Closes #492

zadjii-msft · 2021-04-02T11:15:56Z

Hey uh, what do we do with this now? The correct answer is probably "update to match what we shipped in #7489", yea?

zadjii-msft · 2021-04-02T15:26:28Z

I'd even be cool with slapping a big:

> **Note**: This spec reflects the original plan for implementing support for defterm, circa {whenever it was authored}.
> The actual implementation in [#7489](https://github.com/microsoft/terminal/pull/7489) has diverged from this doc minorly, but is the current source of truth.

at the top of this doc and just calling it a day

miniksa · 2021-04-03T17:33:08Z

I intend to clean this up and submit it still.

PolyacovYury · 2021-04-21T14:00:08Z

Excuse me for spam, if this is one.
Will there be a "manual" on how to actually do this, when this actually reaches the Terminal Preview release?
Current spec seems to focus on "how to achieve this code-wise" rather than "how to achieve this on user side".

DHowett · 2021-04-21T15:47:04Z

@PolyacovYury are you asking as a user who wants to switch their default terminal, or are you asking as a developer who wants to offer one?

If as a user: it is going to be horribly painfully obvious how to do it because we're not going to release a feature like this to millions of people without blogging, documenting, and tweeting about it. 😄

If as a developer: stay tuned; we do not have a solid message here yet.

PolyacovYury · 2021-04-27T02:34:52Z

@DHowett As a user, of course. Good to know, thank you!

P.S. I was just wondering if this is ready to at least try to test out, since #7489 got merged and all.

skyline75489 · 2021-04-27T02:43:03Z

@PolyacovYury Unfortunely the answer is no for most people. This feature requires changes on the OS-side. If you're a Windows insider, you can probably test it out in future insider release.

I don't honestly know if this is available in the latest insider release. Correct me if I'm wrong.

angry-bender · 2021-04-28T09:45:22Z

@PolyacovYury are you asking as a user who wants to switch their default terminal, or are you asking as a developer who wants to offer one?

If as a user: it is going to be horribly painfully obvious how to do it because we're not going to release a feature like this to millions of people without blogging, documenting, and tweeting about it. 😄

If as a developer: stay tuned; we do not have a solid message here yet.

Thank you :-) @DHowett this is a much needed feature, it will be great to have as an option to Win+X. Cant wait to see the release when it comes out of insider. Is there an issue or RSS to follow?

skyline75489 · 2021-04-28T09:49:55Z

@angry-bender I think you can follow Windows Command Line Blog which is good source for all things command line.

pablo8itall · 2021-04-30T09:59:07Z

Probably my most wanted feature, so glad to see some progress on it. If I never see conhost/cmd.exe (which ever it is) again, happy days. I use Terminal everyday for work (Powershell) and fun (wsl/python/DFhack). Makes windows usable for me. Big thanks to all of you.

zadjii-msft

doc/specs/#492 - Default Terminal/spec.md

Add references from PR to this.

miniksa · 2022-02-23T21:22:28Z

@DHowett, @lhecker if I could get some signatures, I'll bring this in finally. It's implemented anyway.

ghost · 2022-05-24T17:06:04Z

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

miniksa self-assigned this Aug 26, 2020

miniksa marked this pull request as draft August 26, 2020 18:15

miniksa commented Aug 26, 2020

View reviewed changes

doc/specs/#492 - Default Terminal/spec.md Outdated Show resolved Hide resolved

miniksa commented Aug 26, 2020

View reviewed changes

doc/specs/#492 - Default Terminal/spec.md Outdated Show resolved Hide resolved

miniksa commented Aug 26, 2020

View reviewed changes

doc/specs/#492 - Default Terminal/spec.md Outdated Show resolved Hide resolved

zadjii-msft requested changes Aug 28, 2020

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 28, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 31, 2020

miniksa mentioned this pull request Aug 31, 2020

Implement Default Terminal #7489

Merged

7 tasks

KalleOlaviNiemitalo mentioned this pull request Sep 7, 2020

wt.exe from command line with named console binary picks the wrong tab icon and wrong tab title #7552

Open

microsoft-github-updates bot changed the base branch from master to main October 22, 2020 00:27

This was referenced Nov 2, 2020

OpenConsole.exe vs conhost.exe, questions #8101

Closed

UIA API versioning #8182

Closed

zadjii-msft mentioned this pull request Dec 1, 2020

Scenario: Windows Terminal 2.0 Process Model Improvements #5000

Closed

80 tasks

skyline75489 mentioned this pull request Feb 19, 2021

When PS is installed on a system with Windows Terminal, please default to that console. #9220

Closed

This comment has been minimized.

Sign in to view

miniksa and others added 5 commits January 13, 2022 17:27

initial defterm spec entry.

4da28c6

More drafting

e85297e

Add a bunch more to the defterm spec.

47c7d80

Migrate spelling-0.0.19 changes from main

d907fdd

Finish off the spec based on what actually happened.

221fb93

miniksa force-pushed the dev/miniksa/defterm_spec branch from 1ffb479 to 221fb93 Compare January 14, 2022 01:28

pull spell patterns from main because something weird happened.

4f0ceb7

This comment has been minimized.

Sign in to view

adjust spelling to satisfy checker.

502c629

zadjii-msft approved these changes Jan 18, 2022

View reviewed changes

doc/specs/#492 - Default Terminal/spec.md Outdated Show resolved Hide resolved

Update spec.md

289ccd9

Add references from PR to this.

miniksa marked this pull request as ready for review February 23, 2022 21:21

lhecker approved these changes Feb 23, 2022

View reviewed changes

miniksa mentioned this pull request Feb 24, 2022

Show/Hide Operations on ::GetConsoleWindow() do not work against Terminal through ConPTY #12570

Closed

miniksa merged commit d0d42c4 into main Feb 25, 2022

miniksa deleted the dev/miniksa/defterm_spec branch February 25, 2022 23:54

ok-nick mentioned this pull request Apr 30, 2022

Make alacritty the default terminal on Windows alacritty/alacritty#6036

Open

zadjii-msft mentioned this pull request Aug 21, 2023

How does "Default Terminal" work? #15853

Closed

ysc3839 mentioned this pull request Sep 19, 2024

Add support for terminal handoff microsoft/node-pty#716

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default Terminal Spec #7414

Default Terminal Spec #7414

miniksa commented Aug 26, 2020 •

edited by zadjii-msft

Loading

miniksa Aug 26, 2020

zadjii-msft Aug 28, 2020

miniksa commented Aug 26, 2020

zadjii-msft left a comment

zadjii-msft Aug 28, 2020

miniksa commented Aug 31, 2020

sylveon commented Sep 13, 2020

DHowett commented Sep 13, 2020

zadjii-msft commented Apr 2, 2021

zadjii-msft commented Apr 2, 2021

miniksa commented Apr 3, 2021

PolyacovYury commented Apr 21, 2021

DHowett commented Apr 21, 2021 •

edited

Loading

PolyacovYury commented Apr 27, 2021

skyline75489 commented Apr 27, 2021

angry-bender commented Apr 28, 2021

skyline75489 commented Apr 28, 2021

pablo8itall commented Apr 30, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zadjii-msft left a comment

miniksa commented Feb 23, 2022

ghost commented May 24, 2022


		## Potential Issues

		[comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted.

Default Terminal Spec #7414

Default Terminal Spec #7414

Conversation

miniksa commented Aug 26, 2020 • edited by zadjii-msft Loading

→Doc Link←

References

PR Checklist

miniksa Aug 26, 2020

Choose a reason for hiding this comment

zadjii-msft Aug 28, 2020

Choose a reason for hiding this comment

miniksa commented Aug 26, 2020

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft Aug 28, 2020

Choose a reason for hiding this comment

miniksa commented Aug 31, 2020

sylveon commented Sep 13, 2020

DHowett commented Sep 13, 2020

zadjii-msft commented Apr 2, 2021

zadjii-msft commented Apr 2, 2021

miniksa commented Apr 3, 2021

PolyacovYury commented Apr 21, 2021

DHowett commented Apr 21, 2021 • edited Loading

PolyacovYury commented Apr 27, 2021

skyline75489 commented Apr 27, 2021

angry-bender commented Apr 28, 2021

skyline75489 commented Apr 28, 2021

pablo8itall commented Apr 30, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zadjii-msft left a comment

Choose a reason for hiding this comment

miniksa commented Feb 23, 2022

ghost commented May 24, 2022

miniksa commented Aug 26, 2020 •

edited by zadjii-msft

Loading

DHowett commented Apr 21, 2021 •

edited

Loading

pablo8itall commented Apr 30, 2021 •

edited

Loading