Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have an option to centre the terminal if a certain InitialPosition value is given #7722

Closed
jethas-bennettjones opened this issue Sep 24, 2020 · 3 comments · Fixed by #9036
Closed

Have an option to centre the terminal if a certain InitialPosition value is given #7722

jethas-bennettjones opened this issue Sep 24, 2020 · 3 comments · Fixed by #9036
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@jethas-bennettjones
Copy link

Description of the new feature/enhancement

I would like to be able to tell Windows Terminal to centre itself on the screen, rather than provide a numerical InitialPosition value.

Proposed technical implementation details (optional)

  1. Provide a value such as "auto-centre" or "centre" to InitialPosition
  2. ???
  3. Profit!
@jethas-bennettjones jethas-bennettjones added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 24, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 24, 2020
@zadjii-msft
Copy link
Member

I... don't hate this actually. I don't think this would be too hard to do, thanks for the suggestion!

@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 25, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 25, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Sep 25, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

I'm on this!

@ghost ghost mentioned this issue Nov 27, 2020
Closed
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 27, 2020
@zadjii-msft zadjii-msft mentioned this issue Feb 4, 2021
Merged
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Feb 4, 2021
@ghost ghost closed this as completed in #9036 Feb 19, 2021
ghost pushed a commit that referenced this issue Feb 19, 2021
@zadjii-msft @kaihugo
Add centerOnLaunch setting (#9036)
ba8bd00 
This PR is a resurrection of #8414. @Hegunumo has apparently deleted
their account, but the contribution was still valuable. I'm just here to
get it across the finish line.

This PR adds new global setting `centerOnLaunch`. When set to `true`,
the Terminal window will be centered on the display it opens on. 

So the interactions are like:

* `initialPos: x,y`, `centered: true`, `launchMode: default`
  center on the monitor that x,y is on 

* `initialPos: x,y`, `centered: true`, `launchMode: maximized`
  maximized on the monitor that x,y is on (centered adds nothing)

* `initialPos: <omitted>`, `centered: true`, `launchMode: default`
  center on the default monitor

* `initialPos: <omitted>`, `centered: true`, `launchMode: focus`
  center, focus mode on the default monitor

* `initialPos: <omitted>`, `centered: true`, `launchMode: maximized`
  maximized on the default monitor (centered adds nothing)

## Validation Steps Performed
I've played with it on multiple different monitors, and it seems to work
on all of them.

Closes #8414 (original PR)
Closes #7722 

Co-authored-by: Kiminori Kaburagi <yukawa_hidenori@icloud.com>
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 19, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9036, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add centerOnLaunch setting microsoft/terminal
Add CenterOnLaunch property
3 participants
@DHowett @zadjii-msft @jethas-bennettjones