-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add centerOnLaunch
setting
#9036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
A few missing things:
- update the schema
- update the docs
- Settings UI
- Option 1: Open a follow-up task to add this to SUI (add it to the correct milestone)
- Option 2: Update it here and now
Remember, AddASetting.md exists to help out a bit. (Note, #8919 is coming in though, so that might make some of this a bit easier.) InitialPosition is not in SUI though, so that'll be a bit annoying. But I guess we could still do some kind of smart behavior for "if launchMode
is not maximized, make centerOnLaunch
appear"
@carlos-zamora RE: settings UI I'm thinking this would make sense to just do all at once with EDIT: see "SUI: Add settings for initalPosition, centerOnLaunch #9075" |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
This PR is a resurrection of #8414. @Hegunumo has apparently deleted
their account, but the contribution was still valuable. I'm just here to
get it across the finish line.
This PR adds new global setting
centerOnLaunch
. When set totrue
,the Terminal window will be centered on the display it opens on.
So the interactions are like:
initialPos: x,y
,centered: true
,launchMode: default
center on the monitor that x,y is on
initialPos: x,y
,centered: true
,launchMode: maximized
maximized on the monitor that x,y is on (centered adds nothing)
initialPos: <omitted>
,centered: true
,launchMode: default
center on the default monitor
initialPos: <omitted>
,centered: true
,launchMode: focus
center, focus mode on the default monitor
initialPos: <omitted>
,centered: true
,launchMode: maximized
maximized on the default monitor (centered adds nothing)
Validation Steps Performed
I've played with it on multiple different monitors, and it seems to work
on all of them.
Closes #8414 (original PR)
Closes #7722
Co-authored-by: Kiminori Kaburagi yukawa_hidenori@icloud.com