Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC 9;9 path seems to be invalid #8930

Closed
jack775544 opened this issue Jan 28, 2021 · 4 comments · Fixed by #8934
Closed

OSC 9;9 path seems to be invalid #8930

jack775544 opened this issue Jan 28, 2021 · 4 comments · Fixed by #8934
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@jack775544
Copy link

jack775544 commented Jan 28, 2021

Environment

Windows build number: Microsoft Windows [Version 10.0.19042.746]
Windows Terminal version (if applicable): 1.6.10272.0

Any other software?
Powershell Core & Powershell 5

Steps to reproduce

I was trying out the new out the new OSC 9;9 reporting in the 1.6 release of the terminal and it seems that when I try to duplicate a pane after setting the path using OSC 9;9 the terminal can never find the location of the path set and shows the error 0x8007010b error.

In my case I have altered my terminal launch profile for powershell to include the -noprofile parameter for easier testing.

Expected behavior

  • Launch Powershell in terminal
  • Run the following
cd 'C:\Program Files\'
"$([char]27)]9;9;`"$($pwd.Path)`"$([char]7)"
  • Run duplicate pane command
  • New pane should open in C:\Program Files

Actual behavior

image

It is important to note that performing the exact same set of commands in ConEmu will correctly open the new pane in Program Files as expected.

Other Notes

Powershell Launch Profile:

{
	"guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
	"hidden": false,
	"name": "PowerShell Core",
	"source": "Windows.Terminal.PowershellCore",
	"commandline" : "C:\\Program Files\\PowerShell\\7\\pwsh.exe -noprofile",
}

Duplicate pane key bind:

{ "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" }
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 28, 2021
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Jan 28, 2021
@zadjii-msft
Copy link
Member

ho boy that sure looks wrong
image

Hmm.
image

I wonder if the double-quotes wrapping the string are confusing it.

/cc @skyline75489

@jack775544
Copy link
Author

Removing the double quotes does seem to fix the issue however the implementation that I saw in oh-my-posh as well as the ConEmu docs both seemed to imply that the double quotes are intended.

@skyline75489
Copy link
Collaborator

Thanks for trying out the feature! I didn’t know there’s OSC;9;9 implementation in oh-my-posh until now. I was baking my own implementation so obviously it is not tested that much. Will take a look today.

@ghost ghost added the In-PR This issue has a related PR label Jan 29, 2021
@ghost ghost closed this as completed in #8934 Feb 4, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 4, 2021
ghost pushed a commit that referenced this issue Feb 4, 2021
This PR fixes the parsing of OSC 9;9 sequences with path surrounded by
quotation marks.

Original OSC 9;9 PR: #8330 

Unit test added. Manually tested with oh-my-posh.

Closes #8930
DHowett pushed a commit that referenced this issue Feb 5, 2021
This PR fixes the parsing of OSC 9;9 sequences with path surrounded by
quotation marks.

Original OSC 9;9 PR: #8330

Unit test added. Manually tested with oh-my-posh.

Closes #8930

(cherry picked from commit 0811c57)
@DHowett DHowett removed the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label Feb 5, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

🎉This issue was addressed in #8934, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants