-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error 0x8007010b could display a more expressive error message - mention the actual starting directory? #9114
Comments
I'm betting something in your prompt is emitting OSC 9;9 to "set the current directory", and we're failing to find that directory. This might be the same root cause as #8930, which was fixed by #8934. Could you do a We might also be able to surface this particular error better. @DHowett thoughts on having this specific error cause the connection to tell the user which directory wasn't found? |
I noticed my issue that I logged is similar to this one. Here is what I get when I run that command.
I set this custom prompt months ago from a tutorial. I'll see if I can find the tutorial and undo the change. |
There's a build of Terminal about to come out that should fix this. Sorry for the issue! 😄 |
I would love to have more expressive error messages ! |
I'm gonna leave this open then and re-purpose this as "we need a more expressive message in this case". |
As an aside,
I'm surprised that this doesn't on its own cause trouble. (Also, doesn't the powershell generator detect this specific instance of powershell preview?) |
Here's my output for
Also, I will note that I've just updated to 1.6.10412.0 and the issue has been fixed. But I agree that a more expressive error message would be nice. Thanks for the fix! |
This is promarily being done to unblock #9223. Prior to this, we'd validate that the user's `startingDirectory` existed here. If it was invalid, we'd gracefully fall back to `%USERPROFILE%`. However, that could cause hangs when combined with WSL. When the WSL filesystem is slow to respond, we'll end up waiting indefinitely for their filesystem driver to respond. This can result in the whole terminal becoming unresponsive. Similarly, with #9223 we want users to be able to specify WSL paths in a profile, but this bit of validation logic totally prevents that from working, because it'll just replace the path with `%USERPROFILE%`. If the path is eventually invalid, we'll display warning in the `ConptyConnection`, when the process fails to launch. Closes #9541 Closes #9114
This is primarily being done to unblock #9223. Prior to this, we'd validate that the user's `startingDirectory` existed here. If it was invalid, we'd gracefully fall back to `%USERPROFILE%`. However, that could cause hangs when combined with WSL. When the WSL filesystem is slow to respond, we'll end up waiting indefinitely for their filesystem driver to respond. This can result in the whole terminal becoming unresponsive. Similarly, with #9223 we want users to be able to specify WSL paths in a profile, but this bit of validation logic totally prevents that from working, because it'll just replace the path with `%USERPROFILE%`. If the path is eventually invalid, we'll display warning in the `ConptyConnection`, when the process fails to launch. Closes #9541 Closes #9114 ![image](https://user-images.githubusercontent.com/18356694/117318675-426d2d00-ae50-11eb-9cc0-0b23c397472c.png)
This is primarily being done to unblock #9223. Prior to this, we'd validate that the user's `startingDirectory` existed here. If it was invalid, we'd gracefully fall back to `%USERPROFILE%`. However, that could cause hangs when combined with WSL. When the WSL filesystem is slow to respond, we'll end up waiting indefinitely for their filesystem driver to respond. This can result in the whole terminal becoming unresponsive. Similarly, with #9223 we want users to be able to specify WSL paths in a profile, but this bit of validation logic totally prevents that from working, because it'll just replace the path with `%USERPROFILE%`. If the path is eventually invalid, we'll display warning in the `ConptyConnection`, when the process fails to launch. Closes #9541 Closes #9114 ![image](https://user-images.githubusercontent.com/18356694/117318675-426d2d00-ae50-11eb-9cc0-0b23c397472c.png) (cherry picked from commit bfc4838)
🎉This issue was addressed in #10045, which has now been successfully released as Handy links: |
🎉This issue was addressed in #10045, which has now been successfully released as Handy links: |
Environment
I've had this happen on the both the windows computers I use, but the above is from the machine I use most. This did use to work, and I haven't changed anything in my setup recently (besides the windows version though normal updates and terminal versions). Unknown how long this has been broken for me, but at least 1.5 weeks.
profiles
insettings.json
:Steps to reproduce
Use the
duplicateTab
command for a hotkey.eg.
Expected behavior
A tab to open of the same type as the current tab.
Actual behavior
I receive an error like
The text was updated successfully, but these errors were encountered: