Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable path validation, add warning #10045

Merged
4 commits merged into from
May 12, 2021
Merged

Commits on May 6, 2021

  1. Disable path validation, add warning

    This is promarily being done to unblock #9223.
    
    Prior to this, we'd validate that the user's `startingDirectory` existed
    here. If it was invalid, we'd gracefully fall back to `%USERPROFILE%`.
    
    However, that could cause hangs when combined with WSL. When the WSL
    filesystem is slow to respond, we'll end up waiting indefinitely for
    their filesystem driver to respond. This can result in the whole terminal
    becoming unresponsive.
    
    Similarly, with #9223 we want users to be able to specify WSL paths in a
    profile, but this bit of validation logic totally prevents that from working,
    because it'll just replace the path with `%USERPROFILE%`.
    
    If the path is eventually invalid, we'll display warning in the
    `ConptyConnection`, when the process fails to launch.
    
    Closes #9541
    Closes #9114
    zadjii-msft committed May 6, 2021
    Configuration menu
    Copy the full SHA
    a13fd5e View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Configuration menu
    Copy the full SHA
    00ae811 View commit details
    Browse the repository at this point in the history
  2. wording nits

    zadjii-msft committed May 12, 2021
    Configuration menu
    Copy the full SHA
    37e5da4 View commit details
    Browse the repository at this point in the history
  3. howd you get there...?

    zadjii-msft committed May 12, 2021
    Configuration menu
    Copy the full SHA
    4f841c6 View commit details
    Browse the repository at this point in the history