-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action to display toast with the CWD of the Terminal #15282
Conversation
In the dirtiest way possible, this seems to work for most "start with this CWD" scenarios.
(cherry picked from commit 0726206)
This comment was marked as resolved.
This comment was marked as resolved.
… of the Terminal
# Conflicts: # src/cascadia/TerminalApp/Resources/en-US/Resources.resw # src/cascadia/TerminalApp/TerminalPage.cpp
@@ -511,6 +511,9 @@ | |||
<data name="OpenWindowRenamerCommandKey" xml:space="preserve"> | |||
<value>Rename window...</value> | |||
</data> | |||
<data name="DisplayWorkingDirectoryCommandKey" xml:space="preserve"> | |||
<value>Display Terminal's current working directory</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too nuanced I think for users to get - it's a debugging feature, and it will NOT show the current working directory of the shell that is hosted in the current tab inside the Terminal. I might keep this one on the drawing board for 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DHowett What if I put this behind DebugFeaturesEnabled
, like the "Break into debugger" action? At least in that case, "you must be this high to ride" applies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, name the action debugTerminalCwd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about both? In this case, I will consider debug
to be the verb 😁
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
shh I have more important things to be doing |
Adds an action to display a toast containing the Terminal's "virtual" CWD.
As described in #4637 (comment).
Useful for debugging #5506 et. al. I almost left it as a debug-only feature, but figured it would be helpful for others in the #4637 landscape of things.