-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action to display toast with the CWD of the Terminal #15282
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
816f8b2
dirty: stash a string as a "virtual" CWD, ala #5506
zadjii-msft 03e6044
cleanup for review
zadjii-msft 553f48d
a toast for showing the CWD of the Terminal. This is for debugging
zadjii-msft c83f174
cleanup for review
zadjii-msft 5c377d8
cleanup from review
zadjii-msft eb97e9f
Merge remote-tracking branch 'origin/main' into dev/migrie/b/5506-vir…
zadjii-msft c01611d
start writing tests
zadjii-msft 51a8df7
huzzah tests pass
zadjii-msft 8c797f8
OKAY it works now
zadjii-msft ddce6eb
Merge branch 'dev/migrie/b/5506-virtual-cwd' into dev/migrie/f/show-cwd
zadjii-msft 45a8194
current
zadjii-msft 1a6cedc
Merge remote-tracking branch 'origin/main' into dev/migrie/f/show-cwd
zadjii-msft aca8d8e
Merge remote-tracking branch 'origin/main' into dev/migrie/f/show-cwd
zadjii-msft 99a9038
well, definitely yank from defaults
zadjii-msft b4250b8
as requested
zadjii-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too nuanced I think for users to get - it's a debugging feature, and it will NOT show the current working directory of the shell that is hosted in the current tab inside the Terminal. I might keep this one on the drawing board for 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DHowett What if I put this behind
DebugFeaturesEnabled
, like the "Break into debugger" action? At least in that case, "you must be this high to ride" appliesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, name the action
debugTerminalCwd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about both? In this case, I will consider
debug
to be the verb 😁