Added selectionBackground to light color schemes #16243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: This is my first PR to open-source projects. I've tried to follow contribution guidelines. If I made any mistakes along the way, I'm more than willing to accept any criticizm. Thanks in advance |
lhecker
approved these changes
Nov 1, 2023
|
Thanks so much for doing this! We have a bug with our handling of color schemes that might cause a problem, but we can fix that. The issue is that the color schemes you have changed get copied into the user's settings... so the changes in this file don't get applied to existing users. We have a pull request out that improves this situation (#12800). |
DHowett
approved these changes
Nov 6, 2023
DHowett
changed the title
|
Thank you for the feedback, can't wait to contribute more to the project in the future. (If I can find an issue fit for my skills that is.) |
DHowett
pushed a commit
that referenced
this pull request
Nov 7, 2023
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them. (cherry picked from commit a5c269b) Service-Card-Id: 91033166 Service-Version: 1.18
DHowett
pushed a commit
that referenced
this pull request
Nov 7, 2023
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them. (cherry picked from commit a5c269b) Service-Card-Id: 91033167 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Nov 7, 2023
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them. (cherry picked from commit a5c269b) Service-Card-Id: 91033166 Service-Version: 1.18
radu-cernatescu
pushed a commit
to radu-cernatescu/terminal
that referenced
this pull request
Nov 8, 2023
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to microsoft#8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them.
DHowett
added a commit
that referenced
this pull request
Jan 12, 2024
- AtlasEngine: Minor bug fixes (GH-16219) - Fix the fix for the fix of nearby font loading (GH-16196) - Added selectionBackground to light color schemes (GH-16243) - Another theoretical fix for a crash (GH-16267) - Fix tabs being printed in cmd.exe prompts (GH-16273) Related work items: MSFT-47266988
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes.
Related to #8716
It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them.