Stop updating AutoSuggestBox on selection #17961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Sep 25, 2024
carlos-zamora
approved these changes
Sep 25, 2024
I don't think it's too critical. But if we're making a servicing release anyway, we may as well. This is a tiny change after all. |
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2024
`AutoSuggestBox` has a `SuggestionChosen` event and any reasonable person would assume that this means one of the items was chosen. But with WinUI it's raised whenever a suggestion is merely highlighted. `QuerySubmitted` is the right event instead. Clearly that naming is a lot better than `SuggestionChosen`, since the property to get the chosen item is called `ChosenSuggestion`. WinUI, like the unrelenting wilderness of a world indifferent to human suffering, stands as a testament to the futility of human aspiration. Closes #17916 ## Validation Steps Performed * Type "Casc" * Move up/down with the arrow keys * Neither the filtered list nor the text updates ✅ * Press Enter on an item * Text updates ✅ (cherry picked from commit bcac999) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTW9-g Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2024
`AutoSuggestBox` has a `SuggestionChosen` event and any reasonable person would assume that this means one of the items was chosen. But with WinUI it's raised whenever a suggestion is merely highlighted. `QuerySubmitted` is the right event instead. Clearly that naming is a lot better than `SuggestionChosen`, since the property to get the chosen item is called `ChosenSuggestion`. WinUI, like the unrelenting wilderness of a world indifferent to human suffering, stands as a testament to the futility of human aspiration. Closes #17916 ## Validation Steps Performed * Type "Casc" * Move up/down with the arrow keys * Neither the filtered list nor the text updates ✅ * Press Enter on an item * Text updates ✅ (cherry picked from commit bcac999) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTW9-o Service-Version: 1.22
Closed
DHowett
added a commit
that referenced
this pull request
Oct 3, 2024
DHowett
added a commit
that referenced
this pull request
Oct 9, 2024
DHowett
added a commit
that referenced
this pull request
Oct 9, 2024
DHowett
pushed a commit
that referenced
this pull request
Oct 23, 2024
I wrote a big comment next to the changes I made. This is a redo of #17961 which had various issues. Closes #17916 Closes #18070 ## Validation Steps Performed * Pressing Enter within the input line doesn't crash ✅ * Type "Cour" and pick Courier New, press Save = Saved ✅ * Pick any other font from the dropdown, press Save = Saved ✅ * Picking an option dismisses focus but not to the tab row ✅ * The first time after launching the SUI, when the setting is still unmodified, when you focus the box and pick an option, it'll unfocus the box ✅ * When the setting is unmodified, and you pick the default (Cascadia Mono), it'll still unfocus the box ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoSuggestBoxhas aSuggestionChosenevent and any reasonableperson would assume that this means one of the items was chosen.
But with WinUI it's raised whenever a suggestion is merely highlighted.
QuerySubmittedis the right event instead. Clearly that naming isa lot better than
SuggestionChosen, since the property to get thechosen item is called
ChosenSuggestion.WinUI, like the unrelenting wilderness of a world indifferent to human
suffering, stands as a testament to the futility of human aspiration.
Closes #17916
Validation Steps Performed