Warn the user if the keyboard service is disabled #8095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
|
We should probably add a section in the docs under troubleshooting for this. Should we provide a link to that in the popup dialog? Also, I'm guessing the answer is "no" but do we want a "disable this warning" setting? |
|
The way to disable this warning is to enable that service. |
DHowett
reviewed
Oct 29, 2020
miniksa
reviewed
Oct 30, 2020
KalleOlaviNiemitalo
suggested changes
Oct 30, 2020
ghost
added
Needs-Author-Feedback
zadjii-msft
added a commit
to MicrosoftDocs/terminal
that referenced
this pull request
Nov 3, 2020
|
So as it turns out, the linter is set to auto pull the latest version, which is of course, broken. IMO, that's the last straw with the linter - I don't think we've gotten anything valuable from it frankly. |
miniksa
reviewed
Nov 4, 2020
miniksa
reviewed
Nov 4, 2020
miniksa
reviewed
Nov 4, 2020
zadjii-msft
commented
Nov 4, 2020
DHowett
reviewed
Nov 4, 2020
Comment on lines
+2682
to
+2694
| DWORD cchBuffer = 0; | ||
| GetServiceDisplayName(hManager.get(), TabletInputServiceKey.data(), nullptr, &cchBuffer); | ||
| std::wstring buffer; | ||
| cchBuffer += 1; // Add space for a null | ||
| buffer.resize(cchBuffer); | ||
|
|
||
| if (LOG_LAST_ERROR_IF(!GetServiceDisplayName(hManager.get(), | ||
| TabletInputServiceKey.data(), | ||
| buffer.data(), | ||
| &cchBuffer))) | ||
| { | ||
| return winrt::hstring{ TabletInputServiceKey }; | ||
| } |
There was a problem hiding this comment.
You might appreciate this helper!
std::wstring serviceName;
wil::AdaptFixedSizeToAllocatedResult(serviceName, [hManager](PWSTR buffer, size_t size, size_t* needed) -> HRESULT {
DWORD cchBuffer{ static_cast<DWORD>(size) };
BOOL const success = GetServiceDisplayName(hManager.get(), TabletInputServiceKey.data(), buffer, &cchBuffer);
RETURN_LAST_ERROR_IF((success == FALSE) && (::GetLastError() != ERROR_INSUFFICIENT_BUFFER));
*needed = cchBuffer = 1; // +1 for the null terminator
return S_OK;
});(this is a nit; I just think it's a cool helper!)
There was a problem hiding this comment.
reckon you've gotta check the HR return from AdaptFixedSize...
DHowett
approved these changes
Nov 4, 2020
Comment on lines
+2682
to
+2694
| DWORD cchBuffer = 0; | ||
| GetServiceDisplayName(hManager.get(), TabletInputServiceKey.data(), nullptr, &cchBuffer); | ||
| std::wstring buffer; | ||
| cchBuffer += 1; // Add space for a null | ||
| buffer.resize(cchBuffer); | ||
|
|
||
| if (LOG_LAST_ERROR_IF(!GetServiceDisplayName(hManager.get(), | ||
| TabletInputServiceKey.data(), | ||
| buffer.data(), | ||
| &cchBuffer))) | ||
| { | ||
| return winrt::hstring{ TabletInputServiceKey }; | ||
| } |
There was a problem hiding this comment.
reckon you've gotta check the HR return from AdaptFixedSize...
Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
DHowett
approved these changes
Nov 4, 2020
miniksa
approved these changes
Nov 4, 2020
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/migrie/f/7886-warn-if-youve-turned-off-the-keyboard
branch
DHowett
pushed a commit
that referenced
this pull request
Nov 9, 2020
 With this PR, the Terminal will check to make sure the "Touch, Keyboard and Handwriting Panel Service" is enabled at startup. If it isn't, then the Terminal won't be able to receive keyboard input (see #4448 and the 20 linked issues to that one). * See #4448 for more details * [x] Closes #7886 * [ ] Should this make #4448 not-open as well? * [x] I work here * [n/a] Tests added/passed * [x] Docs: MicrosoftDocs/terminal#168 I manually set the service to "Disabled", restarted the machine, verified the dialog opens (and that I'm unable to type in the Terminal), then re-set the service to automatic and rebooted, and the dialog doesn't appear. (cherry picked from commit d5d2b77)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
6 tasks
DHowett
pushed a commit
that referenced
this pull request
Feb 22, 2021
Add a setting to turn off the warning if 'Touch Keyboard and Handwriting Panel Service' is disabled. The service might not start in some case, and it doesn't affect the input in some computer. This PR turn off the warning even if the service is disabled. The setting name is "inputServiceWarning". ## Validation Steps Performed I manually set the service to "Disabled", restarted the Terminal, verified the warning up, then set "inputServiceWarning" to false and restarted the Terminal, and the warning didn't appear. References #8095 References #7886 (comment)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
With this PR, the Terminal will check to make sure the "Touch, Keyboard and Handwriting Panel Service" is enabled at startup. If it isn't, then the Terminal won't be able to receive keyboard input (see #4448 and the 20 linked issues to that one).
References
PR Checklist
Validation Steps Performed
I manually set the service to "Disabled", restarted the machine, verified the dialog opens (and that I'm unable to type in the Terminal), then re-set the service to automatic and rebooted, and the dialog doesn't appear.