-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the window is summoned and is already active, minimize it. #9963
Conversation
…ompile a String[]
…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
…safely tear it down. It _seems_ like it.
…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.
…Current-desktop # Conflicts: # src/cascadia/TerminalApp/AppLogic.idl # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h
…/quake-toggleVisibility
6c424f7
to
fe51444
Compare
387d675
to
04752e5
Compare
(cherry picked from commit d3297bdc8740410e9c73c1cc15d5aa9fb5d2f109)
04752e5
to
1032dbb
Compare
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…com/microsoft/terminal into dev/migrie/f/quake-toggleVisibility
I'm fixing the x86 leg break |
{ | ||
VERIFY_IS_TRUE(false, L"We shouldn't need GetWindowDesktopId in the tests."); | ||
return E_FAIL; | ||
} | ||
HRESULT IsWindowOnCurrentVirtualDesktop(HWND topLevelWindow, BOOL* onCurrentDesktop) | ||
IFACEMETHOD(IsWindowOnCurrentVirtualDesktop) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes clang-format did this no i don't like it but oh well
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 🗜️ If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
|
🎉 Handy links: |
This adds a
toggleVisibility
parameter toglobalSummon
.true
(default): when you press the global summon keybinding, and the window is currently the foreground window, we'll minimize the window.false
, we'll just do nothing.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
I've got nothing extra to add here. This one's pretty simple. I'm only targeting #9954 since that one laid so much foundation to build on, with the
SummonBehavior
Validation Steps Performed
Played with this for a while, and it's amazing.