Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the window is summoned and is already active, minimize it. #9963

Merged
merged 109 commits into from
Apr 28, 2021

Commits on Dec 16, 2020

  1. Configuration menu
    Copy the full SHA
    3bef7bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f52d35 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a9cdc8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    36539cf View commit details
    Browse the repository at this point in the history
  5. 1 Configuration menu
    Copy the full SHA
    27ace16 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. HOLY SHIT I GOT THE COMANDLINE TO EXECUTE IN THE CURRENT WINDOW!!!!!!…

    …!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    zadjii-msft committed Dec 17, 2020
    3 Configuration menu
    Copy the full SHA
    9a41647 View commit details
    Browse the repository at this point in the history
  2. add a note to future me

    zadjii-msft committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5cabcfb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    03bfc6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    590b9ff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0579b24 View commit details
    Browse the repository at this point in the history
  6. finish renaming this test

    zadjii-msft committed Dec 17, 2020
    1 Configuration menu
    Copy the full SHA
    a3faed6 View commit details
    Browse the repository at this point in the history
  7. Clean up a lot for review

    zadjii-msft committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9c6eac4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0103331 View commit details
    Browse the repository at this point in the history
  9. Final cleanup for review

    zadjii-msft committed Dec 17, 2020
    1 Configuration menu
    Copy the full SHA
    b4fe1bf View commit details
    Browse the repository at this point in the history
  10. 1 Configuration menu
    Copy the full SHA
    d08e65c View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. pr nits

    zadjii-msft committed Dec 18, 2020
    1 Configuration menu
    Copy the full SHA
    e101efd View commit details
    Browse the repository at this point in the history
  2. This seems to work to create a thread listening for the monarch, and …

    …safely tear it down. It _seems_ like it.
    zadjii-msft committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e1402d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f978a9c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5939636 View commit details
    Browse the repository at this point in the history
  5. 1 Configuration menu
    Copy the full SHA
    c088895 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Configuration menu
    Copy the full SHA
    fa2df47 View commit details
    Browse the repository at this point in the history
  2. Enable audit mode

    zadjii-msft committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    0f5c24f View commit details
    Browse the repository at this point in the history
  3. nits

    zadjii-msft committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    921d915 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00184e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Ask the TerminalApp to parse the commandline, and tell us what the wi…

    …ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.
    zadjii-msft committed Jan 6, 2021
    1 Configuration menu
    Copy the full SHA
    658db6b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    977db46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bcbef34 View commit details
    Browse the repository at this point in the history
  4. notes, comments, cleanup

    zadjii-msft committed Jan 6, 2021
    1 Configuration menu
    Copy the full SHA
    813dbc6 View commit details
    Browse the repository at this point in the history
  5. activate windows

    zadjii-msft committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    0f0df5e View commit details
    Browse the repository at this point in the history
  6. add some tracelogging

    zadjii-msft committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9fc2f0e View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Configuration menu
    Copy the full SHA
    6537686 View commit details
    Browse the repository at this point in the history
  2. mostly just notes

    zadjii-msft committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a75da0a View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    c02f25a View commit details
    Browse the repository at this point in the history
  4. more comments

    zadjii-msft committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    3e39ab9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52b2cb6 View commit details
    Browse the repository at this point in the history
  6. Code cleanup

    zadjii-msft committed Jan 7, 2021
    1 Configuration menu
    Copy the full SHA
    bc492f1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    88ffc6f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    be74b2e View commit details
    Browse the repository at this point in the history
  9. branding

    zadjii-msft committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2a7bc94 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Configuration menu
    Copy the full SHA
    81c09d9 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/main' into dev/migrie/f/the-firs…

    …t-galactic-empire
    
    # Conflicts:
    #	OpenConsole.sln
    #	src/cascadia/Remoting/Microsoft.Terminal.RemotingLib.vcxproj
    #	src/cascadia/Remoting/Monarch.cpp
    #	src/cascadia/Remoting/Monarch.h
    #	src/cascadia/Remoting/Monarch.idl
    #	src/cascadia/Remoting/Peasant.cpp
    #	src/cascadia/Remoting/Peasant.h
    #	src/cascadia/Remoting/Peasant.idl
    #	src/cascadia/Remoting/WindowManager.cpp
    #	src/cascadia/Remoting/WindowManager.h
    #	src/cascadia/Remoting/WindowManager.idl
    #	src/cascadia/Remoting/pch.h
    #	src/cascadia/TerminalApp/AppLogic.h
    #	src/cascadia/TerminalApp/AppLogic.idl
    #	src/cascadia/TerminalApp/TerminalPage.cpp
    #	src/cascadia/TerminalApp/TerminalPage.h
    #	src/cascadia/UnitTests_Remoting/RemotingTests.cpp
    #	src/cascadia/WindowsTerminal/AppHost.cpp
    #	src/cascadia/WindowsTerminal/AppHost.h
    #	src/cascadia/WindowsTerminal/main.cpp
    zadjii-msft committed Jan 8, 2021
    1 Configuration menu
    Copy the full SHA
    c34e4ce View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    5b8ace2 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    689c385 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. 1 Configuration menu
    Copy the full SHA
    59deca1 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    f02969b View commit details
    Browse the repository at this point in the history
  3. man I can't spel

    zadjii-msft committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    b2db317 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Configuration menu
    Copy the full SHA
    d2a3438 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    a65f341 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Configuration menu
    Copy the full SHA
    1c2f8e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71f6b58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18d1a20 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a41bee6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6e7ea61 View commit details
    Browse the repository at this point in the history
  6. Summon the most recent window

      This roundtrips through the monarch to find the MRU peasant.
      Also ensures that we register for the hotkey on the right thread. The monarch will get elected on the BG thread, but registering the hotkey must be on the main thread
    zadjii-msft committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    18099d2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3e5d927 View commit details
    Browse the repository at this point in the history
  8. !!! THIS NEEDS TO BE MOVED TO THE PARENT BRANCH !!!

      > The **low-order word** specifies whether the window is being activated or deactivated.
    zadjii-msft committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    91b52d4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    848682a View commit details
    Browse the repository at this point in the history
  10. man this is crisp

    zadjii-msft committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    1dcb4cb View commit details
    Browse the repository at this point in the history
  11. 1 Configuration menu
    Copy the full SHA
    fee6473 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Configuration menu
    Copy the full SHA
    342d3f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5052d31 View commit details
    Browse the repository at this point in the history
  3. more cleanup

    zadjii-msft committed Jan 29, 2021
    1 Configuration menu
    Copy the full SHA
    eff18d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    5c039ea View commit details
    Browse the repository at this point in the history
  2. We caan now summon based on window name or just use the MRU one. Note…

    …: I haven't tested this at all
    zadjii-msft committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    10779ca View commit details
    Browse the repository at this point in the history
  3. Allow the user to set multiple globalSummon keys, and quakeMode for s…

    …ummoning the _quake window
    zadjii-msft committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    25b31ff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7c2a514 View commit details
    Browse the repository at this point in the history
  5. 1 Configuration menu
    Copy the full SHA
    ac8fef0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Tests and doc comments

    zadjii-msft committed Apr 14, 2021
    1 Configuration menu
    Copy the full SHA
    1fdb6b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    784ec73 View commit details
    Browse the repository at this point in the history
  3. More comments

    zadjii-msft committed Apr 14, 2021
    1 Configuration menu
    Copy the full SHA
    b20222f View commit details
    Browse the repository at this point in the history
  4. Some dead code cleanup

    zadjii-msft committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    9d76c62 View commit details
    Browse the repository at this point in the history
  5. pre emptive spellbot

    zadjii-msft committed Apr 14, 2021
    1 Configuration menu
    Copy the full SHA
    2a2f5cb View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Configuration menu
    Copy the full SHA
    71577fc View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    f892752 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4166afa View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Configuration menu
    Copy the full SHA
    717db81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b2e7a7 View commit details
    Browse the repository at this point in the history
  3. oh man, this will magic summon the window to the current desktop. I'm…

    … shocked that it works, thanks powertoys
    zadjii-msft committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    305e627 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f9eacb View commit details
    Browse the repository at this point in the history
  5. Add support for summoning to the current virtual desktop

      Tested with
    
      ```json
            { "keys": "ctrl+`", "command": { "action": "quakeMode" } },
            { "keys": "ctrl+1", "command": { "action": "globalSummon" } },
            { "keys": "ctrl+2", "command": { "action": "globalSummon", "desktop": "toCurrent" } },
            { "keys": "ctrl+3", "command": { "action": "globalSummon", "desktop": "onCurrent" } },
            { "keys": "ctrl+4", "command": { "action": "globalSummon", "desktop": "any" } },
      ```
    
      And holy god it works so well
    zadjii-msft committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    f71c948 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. cache these results

    zadjii-msft committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    51617cf View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. All of carlos's feedback

    zadjii-msft committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    2eec961 View commit details
    Browse the repository at this point in the history
  2. !! THIS NEEDS TO GO TO THE PARENT BRANCH !!

    (cherry picked from commit 9f9eacb)
    zadjii-msft committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    15a8a9c View commit details
    Browse the repository at this point in the history
  3. replace todo with comment

    zadjii-msft committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    8370789 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Configuration menu
    Copy the full SHA
    4eb1d3a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c215a97 View commit details
    Browse the repository at this point in the history
  3. this test is _fantastic_

    zadjii-msft committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    26d5194 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91372ea View commit details
    Browse the repository at this point in the history
  5. fix a build break

    zadjii-msft committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    045a8db View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Configuration menu
    Copy the full SHA
    c95a429 View commit details
    Browse the repository at this point in the history
  2. When the window is summoned and is already active, minimize it.

      This works like a charm. Let's add settings.
    zadjii-msft committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b5e0f2d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c4238b View commit details
    Browse the repository at this point in the history
  4. update the comment

    zadjii-msft committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0abd963 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    643b860 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/quake-to…

    …Current-desktop
    
    # Conflicts:
    #	src/cascadia/TerminalApp/AppLogic.idl
    #	src/cascadia/WindowsTerminal/AppHost.cpp
    #	src/cascadia/WindowsTerminal/AppHost.h
    zadjii-msft committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    84c1bd9 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    24bfbe6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c2e6d2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aec2561 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22036c2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5940f05 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    06cb41b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    783be75 View commit details
    Browse the repository at this point in the history
  9. pr nits

    zadjii-msft committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    6c424f7 View commit details
    Browse the repository at this point in the history
  10. Merge branch 'dev/migrie/f/quake-toCurrent-desktop' into dev/migrie/f…

    …/quake-toggleVisibility
    zadjii-msft committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    387d675 View commit details
    Browse the repository at this point in the history
  11. Squash merge of Toggle Visibility

    (cherry picked from commit d3297bdc8740410e9c73c1cc15d5aa9fb5d2f109)
    DHowett committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    1032dbb View commit details
    Browse the repository at this point in the history
  12. Merge branch 'dev/migrie/f/quake-toggleVisibility' of https://github.…

    …com/microsoft/terminal into dev/migrie/f/quake-toggleVisibility
    zadjii-msft committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    242f3e2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3e3cb1d View commit details
    Browse the repository at this point in the history
  14. 1 Configuration menu
    Copy the full SHA
    53e3fe9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    fffda9f View commit details
    Browse the repository at this point in the history