Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the RwandaFieldBoundary dataset #1574

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Adding the RwandaFieldBoundary dataset #1574

merged 9 commits into from
Sep 29, 2023

Conversation

calebrob6
Copy link
Member

This dataset is important for the field boundary delineation task.

image

@github-actions github-actions bot added documentation Improvements or additions to documentation datasets Geospatial or benchmark datasets labels Sep 19, 2023
@github-actions github-actions bot added the testing Continuous integration testing label Sep 29, 2023
@calebrob6 calebrob6 added this to the 0.5.0 milestone Sep 29, 2023
@calebrob6
Copy link
Member Author

@yichiac you might be interested in this one

…ake mypy happy even though they are the same thing
docs/api/non_geo_datasets.csv Outdated Show resolved Hide resolved
docs/api/datasets.rst Outdated Show resolved Hide resolved
torchgeo/datasets/rwanda_field_boundary.py Outdated Show resolved Hide resolved
self.root, f"nasa_rwanda_field_boundary_competition_source_{split}"
)
if os.path.exists(path):
num_files = len(os.listdir(path))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could get buggy, for example, if you load one of the images in QGIS and it results in a hidden file left behind

if "mask" in sample:
mask = sample["mask"].numpy()
else:
mask = np.zeros_like(image)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're plotting a mask even if one doesn't exist? Why?

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments are food for thought, they could be addressed in a future patch release without an API change.

@adamjstewart adamjstewart enabled auto-merge (squash) September 29, 2023 10:19
@adamjstewart adamjstewart merged commit b6d78b7 into main Sep 29, 2023
20 checks passed
@adamjstewart adamjstewart deleted the rwanda_crop branch September 29, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants