Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacenet 4 #185

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Spacenet 4 #185

merged 7 commits into from
Oct 12, 2021

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Oct 7, 2021

  • Added SpaceNet 4
  • Added tests and test data for SpaceNet 4

@ashnair1 ashnair1 changed the title Spacenet4 Spacenet 4 Oct 7, 2021
@ashnair1
Copy link
Collaborator Author

ashnair1 commented Oct 7, 2021 •
edited
Loading

TODO: Allow users to specify the subset they want to use.

SpaceNet 4 classifies its imagery based on its nadir angle as follows:

  • Nadir: 0-25 degrees
  • Off-nadir: 26 degrees – 40 degrees
  • Very Off-nadir 40-55 degrees
sn4 = SpaceNet4(
    root="path/to/spacenet4",
    image="PS-RGBNIR",
    angle=["nadir", "off-nadir"],
    download=False,
    checksum=False,
)

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Oct 7, 2021
@ashnair1 ashnair1 force-pushed the spacenet4 branch 2 times, most recently from 9f3306c to e74e569 Compare October 11, 2021 12:20
@ashnair1 ashnair1 marked this pull request as ready for review October 11, 2021 18:23
@ashnair1
Copy link
Collaborator Author

Tests failed due to a ConnectionResetError while a trainer was downloading a checkpoint

@adamjstewart adamjstewart mentioned this pull request Oct 12, 2021
Closed
adamjstewart
adamjstewart reviewed Oct 12, 2021
View reviewed changes
torchgeo/datasets/spacenet.py Outdated Show resolved Hide resolved
torchgeo/datasets/spacenet.py Outdated Show resolved Hide resolved
torchgeo/datasets/spacenet.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart merged commit 73215d2 into microsoft:main Oct 12, 2021
@ashnair1 ashnair1 deleted the spacenet4 branch October 13, 2021 02:29
@ashnair1 ashnair1 mentioned this pull request Oct 13, 2021
Closed
7 tasks
@adamjstewart adamjstewart added this to the 0.1.0 milestone Nov 20, 2021
@adamjstewart
Copy link
Collaborator

I just noticed that labels.json is empty. This causes issues with older versions of fiona. Was this on purpose (like is it possible for this file to be empty in the dataset) or should we added data to labels.json?

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Jun 13, 2022 •
edited
Loading

It was on purpose. SpaceNet4 has some images with empty label files.

yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@ashnair1
Spacenet 4 (microsoft#185)
d335a98 
* Add SpaceNet4

* Add tests

* Update docs

* Add option to choose angle subset

* Remove AssertionError and update docs

* Coverage fix

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ashnair1 @adamjstewart