Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min kornia version to support PadTo #350

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Jan 2, 2022

PadTo was added in kornia 0.5.11 (kornia/kornia#1286). This PR updates the min version accordingly. Currently K.PadTo is only used in the OSCDDatamodule (here).

@ashnair1 ashnair1 changed the title Update min kornia version Update min kornia version to support PadTo Jan 2, 2022
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I may need to add a step in our release procedure to confirm the minimum version of each dep. I'm hopeful for pypa/pip#8085 but it doesn't seem to be making a lot of progress.

@adamjstewart adamjstewart added this to the 0.2.1 milestone Jan 2, 2022
@adamjstewart adamjstewart merged commit 065fd1e into microsoft:main Jan 2, 2022
@ashnair1 ashnair1 deleted the min-kornia branch January 2, 2022 16:37
adamjstewart pushed a commit that referenced this pull request Mar 19, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants