Drop Python 3.6 support #482
Conversation
There was a problem hiding this comment.
Readthedocs build failing with AttributeError: module 'jinja2.utils' has no attribute 'escape' due to jupyter/nbconvert#1736, either pin jinja2 explicitly or wait for upstream to fix things. Otherwise this looks good to me once the rest of the test suite passes.
Edit: Whoops, spoke too soon. Need to check why Windows builds are failing.
|
Not sure why we're having fiona issues all of a sudden. |
|
Yep, for RtD, see #480 (comment). If this isn't fixed soon I'll pin. |
See Toblerity/Fiona#1030 and linked thread. |
|
Thanks for the pointer. It's still not clear why my 2nd commit would change something in the install process. I don't see a new release of any possible conflicting packages in the last couple of days. |
Between your first commit 23hrs ago and the one 1hr ago, it seems like the fiona conda-forge package had a new build about 21 hrs ago (conda-forge/fiona-feedstock#191). Looking at that PR however, I can't really see why that would break things on Windows. |
|
The fiona Windows issue should be resolved for now (see conda-forge/fiona-feedstock#192 (comment)). The green tests here confirm that? |
Yes, it seems like we're picking up the older, non-broken version of fiona now and the tests all pass. Thanks Joris! @adamjstewart, remember to disable the required checks on Python 3.6 after merging this PR 😉 |
* Drop Python 3.6 support * pandas 0.23.2+ required for Python 3.7+ support * Update environment.yml too
* Drop Python 3.6 support * pandas 0.23.2+ required for Python 3.7+ support * Update environment.yml too
Python 3.6 is no longer supported by the Python Software Foundation, nor is it supported by PyTorch. This PR drops Python 3.6 support. All users should upgrade to a modern version of Python in order to use future TorchGeo releases.
The biggest new language feature in Python 3.6 is the ability to use:
This allows us to use annotation capabilities from Python 3.10 in Python 3.7–3.9 by avoiding annotation evaluation at run-time. I'll add this in a separate PR since it's a more controversial change.
Reboot of #326
Closes #413
@weiji14