This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
add react-a11y-iframes to recommended ruleset #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
Type: Breaking Change
PR: Waiting for Reviewer
|
Hmm, I don't know that we can add it to the recommended ruleset. TSLint core doesn't change |
|
Interesting. Learnt something new 😄. |
JoshuaKGoldberg
added
Status: Blocked
3 tasks
|
@drexler thank you for your vigilance. As JoshuaKGoldberg mentioned - new rules shouldn't be part of recommended configuration until next major release. I will close this PR in favor of #809 that creates additional config to include recommended rules in minor versions. Please let me know if you have any questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Adds react-a11y-iframes to recommended ruleset. This was missing from #692, i reckon.