Revamped configs into 'core', 'latest', and (legacy) 'recommended'

[JoshuaKGoldberg]

PR checklist

• Addresses an existing issue: starts on Don't recommend no-use-before-declare or other deprecated or legacy rules #649; fixes Stop extending from TSLint's ruleset in the published ruleset #677; starts on Better document and support auto-generated configs for contributors #700; fixes Stop including library-specific rules in the recommended ruleset #716
• New feature, bugfix, or enhancement
• Documentation update

Overview of change:

Those three config files now exist as .json under /configs; they're copied to dist/build/configs. recommended.json becomes tslint.json as well.

Is there anything you'd like reviewers to focus on?

Does this look like a reasonable way to manage configurations for foreseeable future?

[VincentLanglet]

@JoshuaKGoldberg The same way tslint expose a tslint:all config, you may create a tslint-microsoft-config:all config.

And I, personally, would loved a tslint-microsoft-config:a11y but i'm may be the only one.

[JoshuaKGoldberg]

:all

Yes!! Great idea @VincentLanglet, will do.

Edit: looking through, it seems like latest.ts is already what :all would be. Are there other rules/options missing?

:a11y

Also strongly in support of this! But - I think it would be better, long-term, to move those rules to tslint-react, as it's been confusing to many users where different contributed rules come from & why. Will file issues there.

[VincentLanglet]

:all

Yes!! Great idea @VincentLanglet, will do.

Edit: looking through, it seems like latest.ts is already what :all would be. Are there other rules/options missing?

I didn't have rules in mind. I was just thinking it was the same naming than tslint configs :

• recommended is a subset of all rules, minor version doesn't add breaking changes.
• latest is the recommended rules for the next major version, but still a subset of all rules.
• all is all.

If you're going to do:

• stable every rules but without breaking changes for minor version.
• latest every rules. Will be the stable of the next major version.

You may rename the latest to all

:a11y

Also strongly in support of this! But - I think it would be better, long-term, to move those rules to tslint-react, as it's been confusing to many users where different contributed rules come from & why. Will file issues there.

It's not a bad idea to move those rules to tslint-react. But it's not the same maintainers (Microsoft vs palantir) ; i don't know the needs and consequences.
Anyway it will be a big breaking change. The :a11y can be a first step.

[IllusionMH]

There are couple fixes that are required for code and couple of questions.

According to README.md - it stable configuration will be changes once before major release. Therefore, it makes sense to make stable.json as static file and automatically generate latest.json.
With current approach - it will be really easy to forget to add rule to latest.json and it will slip into stable.json potentially breaking promise of update it only on major versions.

[IllusionMH]

Found second rule that was added after 6.0.0 and shouldn't be in stable.json

[JoshuaKGoldberg]

Thanks for the feedback you two! I agree with what looks like everything that was suggested. 😄

Changed the names of the configurations to be:

• recommended.json: aliased by "extends": ["tslint-microsoft-contrib/recommended"]
• latest.json: aliased by "extends": ["tslint-microsoft-contrib/latest"]
• legacy.json: aliased by "extends": ["tslint-microsoft-contrib"], with a note that that will eventually be an alias for recommended.json.

Thoughts?

Rule configs are, for now, still in configs/ and copied to dist/build/, but once the repository changes to in-place (#825), they can be moved to the root directory.

Filed palantir/tslint-react#202 for moving a11y rules into tslint-react. If that doesn't see traction any time soon (it looks like that repository hasn't had much maintenance since June 2018...), we can add the equivalent here. Let's discuss that later on?

[IllusionMH]

Thanks! After latest changes PR looks great and can be merged as is.
Only one minor comment that I'm not sure should be addressed.

[JoshuaKGoldberg]

Whoohoo, thanks for the reviews @IllusionMH & @VincentLanglet! This'll be available in the next release.