[feat] Add support for cleaning up disposable instances #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xapphire13
commented
Oct 18, 2020
| @@ -36,7 +37,9 @@ export const typeInfo = new Map<constructor<any>, ParamInfo[]>(); | |||
|
|
|||
| /** Dependency Container */ | |||
| class InternalDependencyContainer implements DependencyContainer { | |||
| private _registry = new Registry(); | |||
There was a problem hiding this comment.
Should have probably done this in a separate PR. But the leading _ for private fields isn't really recommended by anyone these days. removing
| @@ -540,6 +541,14 @@ export class Bar implements IBar { | |||
| } | |||
| ``` | |||
|
|
|||
| # Disposable instances | |||
| All instances create by the container that implement the [`Disposable`](./src/types/disposable.ts) | |||
There was a problem hiding this comment.
Nit: spelling "created"
| expect(bar.disposed).toBeTruthy(); | ||
| }); | ||
|
|
||
| it("disposes all instances of the same type", () => { |
There was a problem hiding this comment.
Question - what happens for array-type (@injectAll type) resolutions - do we resolve each element in the array?
| } | ||
| } | ||
|
|
||
| it("renders the container useless", () => { |
There was a problem hiding this comment.
It may be useful to have a UT that ensures that register() and resolve() also fail.
| @@ -360,9 +385,14 @@ class InternalDependencyContainer implements DependencyContainer { | |||
| return childContainer; | |||
| } | |||
|
|
|||
| public dispose(): void { | |||
There was a problem hiding this comment.
Maybe this could be an async method.
Take for example https://www.npmjs.com/package/redis QUIT command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
cc: @mikl