Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add support for cleaning up disposable instances, part deux #183

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

mikl
Copy link
Contributor

@mikl mikl commented Oct 29, 2021

As follow-up to /pull/132 by @Xapphire13 here’s a PR that addresses some of the points raised in that PR:

  1. More test coverage for what happens if you try to use a disposed container.
  2. Support for async disposables.
  3. Minor typo fixes.

That leaves the question raised by @MeltingMosaic:

what happens for array-type (@injectAll type) resolutions - do we resolve each element in the array?

For those I’m not quite sure what to do. Any guidance?

Closes #127

@ghost
Copy link

ghost commented Oct 29, 2021

CLA assistant check
All CLA requirements met.

@MeltingMosaic
Copy link
Collaborator

@Xapphire13 , could you take a look? I will too, but you probably have more context here.

Copy link
Collaborator

@Xapphire13 Xapphire13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this change!

@mikl
Copy link
Contributor Author

mikl commented Nov 8, 2021

Thanks.

I get this warning message:

First-time contributors need a maintainer to approve running workflows.

As explanation to why the tests are not running. Could someone with access approve it?

@MeltingMosaic MeltingMosaic merged commit 675c3c4 into microsoft:master Feb 25, 2022
@blake-mealey
Copy link

My team would like to use this feature. When can we expect the latest version including this change to be released?

@mikl mikl deleted the x13-disposable branch September 21, 2022 08:54
@mikl
Copy link
Contributor Author

mikl commented Sep 21, 2022

@blake-mealey this change was already included in the latest release (4.7.0). You can go ahead and use Disposable in your project, I already do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container.hasInstances() or some other way to tell if instances exist without creating new ones
4 participants