Port IsSourceFileFromExternalLibrary, fix node18 emit #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschwenk
commented
Jun 18, 2025
| @@ -970,6 +970,7 @@ func (p *Project) GetFileNames(excludeFilesFromExternalLibraries bool, excludeCo | |||
| result := []string{} | |||
| sourceFiles := p.program.GetSourceFiles() | |||
| for _, sourceFile := range sourceFiles { | |||
| // !! This is probably ready to be implemented now? | |||
There was a problem hiding this comment.
Because we have IsSourceFileFromExternalLibrary
jakebailey
reviewed
Jun 18, 2025
jakebailey
reviewed
Jun 18, 2025
jakebailey
reviewed
Jun 19, 2025
testdata/baselines/reference/submodule/conformance/typingsLookup4.js.diff
Outdated
Show resolved
Hide resolved
|
I still have more stuff to push; there are other weird things here that need to be fixed before this is ready. |
sheetalkamat
requested changes
Jun 19, 2025
|
Okay, well that was annoying |
jakebailey
reviewed
Jun 19, 2025
.../baselines/reference/submodule/conformance/nodeModulesExportsSourceTs(module=node18).js.diff
Outdated
Show resolved
Hide resolved
jakebailey
changed the title
sourceFileMayBeEmitted
sheetalkamat
approved these changes
Jun 20, 2025
weswigham
approved these changes
Jun 20, 2025
This was referenced Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1215