-
Notifications
You must be signed in to change notification settings - Fork 578
Enable error baselines #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dca61ec
to
6cf997a
Compare
8452ada
to
4edaa88
Compare
Part of the problem is that when we check files, we can issue errors on files other than those being checked. When we are using multiple checkers, we have to make sure to ask all other checkers for their errors too, that fixed about half of the failures. The rest are some other problem. |
|
Other than those failures, though, everything does actually seem to be working with concurrent checking. |
After talking with @ahejlsberg, it seems like the first one is inherent and mostly unsolvable; we probably will have to just have a concurrent variant or just skip the test in concurrent mode. For The others, who knows 😄 |
Daniel's 3 PRs reduced the number of differences by some 60k lines. Awesome. |
With main merged in, down another 20k lines of diffs. |
I've updated the PR to skip the tests which fail in concurrent mode for now. This should be ready to go in. |
Includes #424, but still has other problems, such as:
TestCompilerBaselinesSubmodule/compiler/unreachableDeclarations.ts_preserveconstenums=false/error
is nondeterministic.SourceFileAffecting
list did not consider the options the binder uses.hereby tests --concurrentTestPrograms
, concurrent checking causes problems for any diagnostics that works cross-file, like duplicate identifiers, mismatching type params.TestCompilerBaselinesSubmodule/compiler/jsFileCompilationDuplicateFunctionImplementation.ts/error
TestCompilerBaselinesSubmodule/conformance/duplicateNumericIndexers.ts/error
TestCompilerBaselinesSubmodule/conformance/nodeModulesSynchronousCallErrors.ts_module=node16/error