[Bug]: Protobuf emitter incorrect rpc request type #3534
Assignees
Labels
Comments
|
Thanks for pointing this out. A bit of missing logic in the emitter was causing the parameters to be considered a local model rather than an external model. The following PR addresses this issue: #3561 |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 11, 2024
…ses. (#3561) Closes #3534 Closes #3556 This PR adds cross-package resolution in some cases where it was missing. In the case of operation inputs, missing effective model type calculation was causing some input types not to be resolved to external packages. In the case of map value types, the calculation of the right hand side type did not correctly account for the possibility of the type being in another package, and it now uses the same machinery as other type references to instrument imports and cross-package references. The existing scenario test has been extended to prevent regressions and also extended to test arrays for good measure, though those were working as expected. --------- Co-authored-by: Will Temple <will@wtemple.net> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The protobuf emitter drops the package prefix from the request type for services that use an imported model as the args.
Reproduction
https://typespec.io/playground?c=aW1wb3J0ICJAdHlwZXNwZWMvcHJvdG9idWYiOw0KDQp1c2luZyBUeXBlU3BlYy5Qxx3FHEBwYWNrYWdlKHsNCiAgbmFtZTogIm15c2hhcmVkIiwNCn0pDQrEF3NwYWNlIE15U8UaIMUvbW9kZWwgRHVtbXnGESAgQGZpZWxkKDEpIHg6IHN0cmluZzvEGn0NCn3ccGVydmljZdVxxhvGYUDoAL0uxzLEFWludGVyZs0uc8YvICBlY2hvKC4uLugAuS7lAK4pOukAysYR6wCk&e=%40typespec%2Fprotobuf&options=%7B%7D
Checklist
The text was updated successfully, but these errors were encountered: