[protobuf] Handle cross-package references correctly in some buggy cases. #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witemple-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
This was referenced Jun 11, 2024
timotheeguerin
approved these changes
Jun 11, 2024
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3561/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3561/ |
This was referenced Jul 5, 2024
This was referenced Jul 20, 2024
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3534
Closes #3556
This PR adds cross-package resolution in some cases where it was missing.
In the case of operation inputs, missing effective model type calculation was causing some input types not to be resolved to external packages.
In the case of map value types, the calculation of the right hand side type did not correctly account for the possibility of the type being in another package, and it now uses the same machinery as other type references to instrument imports and cross-package references.
The existing scenario test has been extended to prevent regressions and also extended to test arrays for good measure, though those were working as expected.