-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect template instantiation stack #4806
Merged
timotheeguerin
merged 22 commits into
microsoft:main
from
timotheeguerin:template-instantiation-stack
Nov 4, 2024
Merged
Collect template instantiation stack #4806
timotheeguerin
merged 22 commits into
microsoft:main
from
timotheeguerin:template-instantiation-stack
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
compiler:core
Issues for @typespec/compiler
label
Oct 21, 2024
You can try these changes here
|
timotheeguerin
commented
Oct 22, 2024
timotheeguerin
commented
Oct 22, 2024
timotheeguerin
requested review from
RodgeFu,
bterlson,
markcowl and
allenjzhang
as code owners
October 22, 2024 21:06
…plate-instantiation-stack
…plate-instantiation-stack
chrisradek
approved these changes
Nov 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
To improve #4806 need to cleanup the path resolution close #2274 ### Before ![image](https://github.com/user-attachments/assets/fe2832ed-b794-4c80-b25a-157aeae3bd07) ### After - From parent folder ![image](https://github.com/user-attachments/assets/e210fd50-e154-4e34-8129-3e6eae8a6018) - From same folder ![image](https://github.com/user-attachments/assets/fb47894b-70df-4857-9a5f-451c9ece5355)
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
microsoft#1317 ## CLI ![image](https://github.com/user-attachments/assets/de8e30bf-cba8-4908-b687-2c6ce5a93d1b) ## IDE Error at the original location <img width="1187" alt="image" src="https://github.com/user-attachments/assets/02d0b2df-65f7-4c43-b60d-8fab3b569046"> Error at the template instantitiation <img width="988" alt="image" src="https://github.com/user-attachments/assets/06785dce-de85-4b1a-842f-fda0a6f87f1a">
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
To improve microsoft#4806 need to cleanup the path resolution close microsoft#2274 ### Before ![image](https://github.com/user-attachments/assets/fe2832ed-b794-4c80-b25a-157aeae3bd07) ### After - From parent folder ![image](https://github.com/user-attachments/assets/e210fd50-e154-4e34-8129-3e6eae8a6018) - From same folder ![image](https://github.com/user-attachments/assets/fb47894b-70df-4857-9a5f-451c9ece5355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1317
CLI
IDE
Error at the original location
Error at the template instantitiation