Diagnostic path log relative to current working dir

[timotheeguerin]

To improve #4806 need to cleanup the path resolution

close #2274

Before

After

• From parent folder
  

• From same folder
  

[azure-sdk]

All changed packages have been documented.

• ✅ @typespec/compiler
• ✅ @typespec/http-server-javascript
• ✅ @typespec/protobuf

Show changes

@typespec/compiler - feature ✏️

CLI logs diagnostic source path relative to the CWD.

@typespec/http-server-javascript - internal ✏️

@typespec/protobuf - internal ✏️

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	📚 Next docs

[markcowl]

Will this impact tsv logs in the azure-rest-api-specs repo? Can we try this change there to ensure no issues (unsure if there ia any output processing going on)

The change itself looks good and also useful

[timotheeguerin]

I don't think so, @mikeharder is that going to be a problem

[mikeharder]

I don't think so, @mikeharder is that going to be a problem

Should be fine for now, since we just show text output to user, we don't parse it.

If we wanted to get fancy, we could try to integrate TypeSpecValidation more with GitHub, where errors from tsp compile inside TSV could be promoted all the way to a "GitHub Error" with file and line numbers, and would appear in your code review diff. I think I'll open a feature request for this. But again, for now this change is fine.