Make Configuration.OutputDirectory public #5228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| @@ -150,7 +150,7 @@ private static class Options | |||
| /// <summary> Gets the namespace for the models. </summary> | |||
| public string ModelNamespace { get; } | |||
|
|
|||
| internal string OutputDirectory { get; } | |||
| public string OutputDirectory { get; } | |||
There was a problem hiding this comment.
Looking at the usage, I don't think we need this to be public in order to accomplish the goal of adding an IsAzureArm property to the Azure plugin.
There was a problem hiding this comment.
Replied Azure/azure-sdk-for-net#47374 (comment)
inputLibrary is virtual, but without Configuration.OutputDirectory available it's impossible for sub-plugin to override it.
|
Offline synced with @JoshLove-msft, we will not introduce the inheritance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure plugin needs to override InputLibrary, which needs
Configuration.OutputDirectoryas input.The actual usage is in Azure/azure-sdk-for-net#47374