Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Configuration.OutputDirectory public #5228

Closed
wants to merge 5 commits into from
Closed

Make Configuration.OutputDirectory public #5228

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eca252
Make Configuration.OutputDirectory public
live1206 Nov 29, 2024
eee3adb
Merge branch 'main' into extend-inputlibrary
live1206 Nov 29, 2024
31f3e8e
remove unnecessary lazy for InputLibrary
live1206 Nov 29, 2024
095d7a6
Merge branch 'extend-inputlibrary' of https://github.com/live1206/typ…
live1206 Nov 29, 2024
8ab4c13
Revert "remove unnecessary lazy for InputLibrary"
live1206 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ private static class Options
/// <summary> Gets the namespace for the models. </summary>
public string ModelNamespace { get; }

internal string OutputDirectory { get; }
public string OutputDirectory { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the usage, I don't think we need this to be public in order to accomplish the goal of adding an IsAzureArm property to the Azure plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied Azure/azure-sdk-for-net#47374 (comment)

inputLibrary is virtual, but without Configuration.OutputDirectory available it's impossible for sub-plugin to override it.

typespec/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/CodeModelPlugin.cs

Line 67 in b9e5648

public virtual InputLibrary InputLibrary => _inputLibrary.Value;


internal static UnreferencedTypesHandlingOption UnreferencedTypesHandling { get; private set; } = UnreferencedTypesHandlingOption.RemoveOrInternalize;

Expand Down
Loading