Add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults #26
Conversation
|
Thanks for the PR! This LGTM, though we should continue to search for a better solution for CUDA in the future that doesn't require modifying the vcpkg binary. |
|
@ras0219-msft While this fix came out of my attempt to fix CMake CUDA language support in the vcpkg environment, in the end this didn't fix anything for my own port, since as far as I can tell the versioned CUDA_PATH environment variables are only being used by the MSVC CMake generator, which doesn't seem to be used that often across vcpkg, if at all? The underlying cause is that until now, the CMake generators that don't come directly with associated compilers require nvcc to be present in PATH, not just reachable through CUDA_PATH. So in the end, it might be sufficient to list CUDA_PATH itself directly. This will probably be fixed in CMake 3.21, but of course I cannot vouch for how well this works in environments with multiple CUDA versions, users will probably have to specify and KEEP_ENV_VARS CUDACXX manually there for this to work with Ninja. |
The following PRs are included: * hopefully fix crash in constraints (#60) * [vcpkg] allow --version to check the version (#50) * Remove baseline warning (#27) * [git] always pass autocrlf=false (#58) * ignore QtCreator CMake project files (#54) * ignore .DS_store files (#53) * [vcpkg] x-add-version now also checks if the manifest file is properly formatted (#43) * hopefully fix ci issue #16773 (#34) * Add docs to set VCPKG_ROOT to run tests (#45) * [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (#44) * add clang-format version to format-cxxcode (#41) * [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (#40) * [supports] Add `native` identifier expression and x-check-support command (#29) * [metrics] Split reporting of installs into name:triplet (#39) * [vcpkg] Improve error when accessing missing feature (#38) * [vcpkg] Allow shallow git registries (#37) * Disable git autocrlf when archiving tree (#36) * Use only named packages from extra registries (#35) * [registries] add metrics (#30) * Add vcpkg policy cmake helper port support (#17) * [osx] add support for rosetta (#23) * don't build tls12-download unless it's needed (#33) * Add new telemetry points for versioning (#21) * add cmake_minimum_required to vcpkg_tags (#25) * [x-add-versions] Perform atomic replacement of versioning files (#28) * [tools] support gsutil (#19) * add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (#26) * Add finite timeout on CURL metrics endpoint. (#22) * fix UB in make_error_code(utf8_errc) (#18)
vcpkg right now can't build CUDA ports with version 11.1 and 11.2, since the associated environment variables aren't being forwarded.