Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable git autocrlf when archiving tree #36

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Conversation

aee11
Copy link
Contributor

@aee11 aee11 commented Mar 23, 2021

Ensures that file endings are consistent between the ports and the versioned port under versioning.

Fixes microsoft/vcpkg#16615 (comment) (verified locally). Before this fix, a patch with LF endings could end up with CRLF endings on Windows causing corrupt patch issues.

Ensures that file endings are consistent between the ports and the versioned port under `versioning`.

Fixes microsoft/vcpkg#16615 (comment). Before this fix, a patch with LF endings could end up with CRLF endings on Windows causing corrupt patch issues.
aee11 and others added 3 commits March 23, 2021 22:55
@aee11 aee11 changed the title Inherit gitattributes from the vcpkg repository when archiving tree Use autocrlf=false when archiving tree Mar 23, 2021
@aee11 aee11 changed the title Use autocrlf=false when archiving tree Disable git autocrlf when archiving tree Mar 23, 2021
@ras0219-msft
Copy link
Contributor

Thanks for the fix!

@ras0219-msft ras0219-msft merged commit 63b913a into microsoft:main Mar 24, 2021
strega-nil added a commit that referenced this pull request Apr 15, 2021
The following PRs are included:

* hopefully fix crash in constraints (#60)
* [vcpkg] allow --version to check the version (#50)
* Remove baseline warning (#27)
* [git] always pass autocrlf=false (#58)
* ignore QtCreator CMake project files (#54)
* ignore .DS_store files (#53)
* [vcpkg] x-add-version now also checks if the manifest file is properly formatted (#43)
* hopefully fix ci issue #16773 (#34)
* Add docs to set VCPKG_ROOT to run tests (#45)
* [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (#44)
* add clang-format version to format-cxxcode (#41)
* [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (#40)
* [supports] Add `native` identifier expression and x-check-support command (#29)
* [metrics] Split reporting of installs into name:triplet (#39)
* [vcpkg] Improve error when accessing missing feature (#38)
* [vcpkg] Allow shallow git registries (#37)
* Disable git autocrlf when archiving tree (#36)
* Use only named packages from extra registries (#35)
* [registries] add metrics (#30)
* Add vcpkg policy cmake helper port support (#17)
* [osx] add support for rosetta (#23)
* don't build tls12-download unless it's needed (#33)
* Add new telemetry points for versioning (#21)
* add cmake_minimum_required to vcpkg_tags (#25)
* [x-add-versions] Perform atomic replacement of versioning files (#28)
* [tools] support gsutil (#19)
* add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (#26)
* Add finite timeout on CURL metrics endpoint. (#22)
* fix UB in make_error_code(utf8_errc) (#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struggling with differences in abi_info and build failures with binarycaching
2 participants