-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move toolchain decision making entirely into the tool #350
Move toolchain decision making entirely into the tool #350
Conversation
as said in microsoft/vcpkg#22831. Do you really want to move it into the tool? I mean the triplet would be the correct location to simply set I mean yeah it would be a breaking change for some custom triplets but it would be quite simple to inform users that they need to set |
I don't think we can make that breaking change any time soon -- though we could consider making it deprecated. In that light, I think this change is a pure win. Even with this change, we could add |
Co-authored-by: Billy O'Neal <bion@microsoft.com>
I'm pretty sure this change is what broke a lot of the UWP ports in
Should we revert this for now? |
Indeed:
|
This reverts commit f3841c4.
This PR is a needed tool change to enable microsoft/vcpkg#22831 and comes with the added benefit of removing duplicate toolchain selection logic across the many helper scripts. With this, ports and helpers may always assume that
VCPKG_CHAINLOAD_TOOLCHAIN_FILE
is defined to the correct toolchain to pull in.+@Neumann-A for review