Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake-user] Don't use internal toolchains #27782

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 12, 2022

github-actions[bot]
github-actions bot previously approved these changes Nov 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • scripts/test_ports/cmake-user/portfile.cmake

github-actions[bot]
github-actions bot previously approved these changes Nov 12, 2022
@dg0yt dg0yt marked this pull request as ready for review November 12, 2022 06:59
@Cheney-W Cheney-W added category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines labels Nov 14, 2022
@@ -53,10 +52,6 @@ else()
vcpkg_find_acquire_program(NINJA)
endif()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is microsoft/vcpkg-tool#350

@BillyONeal
Copy link
Member

Thanks!

@BillyONeal BillyONeal merged commit 6fe2b93 into microsoft:master Nov 14, 2022
@dg0yt dg0yt deleted the cmake-user-toolchain branch November 15, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants