#34 does not work correctly when host_triplet = target_triplet #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
approved these changes
May 5, 2021
Comment on lines
+308
to
+317
| bool excluded = false; | ||
| if (spec.triplet() == host_triplet) | ||
| { | ||
| return Util::Sets::contains(host_exclusions, spec.name()); | ||
| excluded = excluded || Util::Sets::contains(host_exclusions, spec.name()); | ||
| } | ||
| else | ||
| if (spec.triplet() == target_triplet) | ||
| { | ||
| return Util::Sets::contains(exclusions, spec.name()); | ||
| excluded = excluded || Util::Sets::contains(exclusions, spec.name()); | ||
| } | ||
| return excluded; |
There was a problem hiding this comment.
My optimizer brain hates mixing the control flow domain and the value domain. (Saying 'perf doesn't matter here leave me alone Bill' is a totally OK response :))
How about:
auto&& triplet = spec.triplet();
auto&& name = spec.name();
return (triplet == host_triplet && Util::Sets::contains(host_exclusions, name))
|| (triplet == target_triplet && Util::Sets::contains(exclusions, name));
There was a problem hiding this comment.
perf doesn't matter here leave me alone bill ;)
There was a problem hiding this comment.
To be honest I find the return expression a bit clearer too but 🤷♂️
ras0219-msft
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that bug