Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] skip lists also skip host ports #16773

Closed
strega-nil opened this issue Mar 18, 2021 · 2 comments
Closed

[ci] skip lists also skip host ports #16773

strega-nil opened this issue Mar 18, 2021 · 2 comments
Assignees
@JackBoosY
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@strega-nil
Copy link
Contributor

There are some ports which are host-only; these ports should be skipped on non-native triplets in CI. However, we have an issue where those skips for the target also become skips for the host.

In commands.ci.cpp, line 537, we need to check if the action is a host port or not.
@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Mar 19, 2021
@autoantwort
Copy link
Contributor

Is this also the reason why in the mailio pr (#16696) the pipeline succeeded because the port was not tested but in reality the port does not build on uwp?

strega-nil added a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
@strega-nil @ras0219
hopefully fix ci issue microsoft#16773 (microsoft#34)
fb34750 
* hopefully fix ci issue microsoft#16773

* format & fix build

* ooh, new clang-format version

* add host exclusions

* format!

* oops

* format with the right clang-format

* Apply suggestions from code review

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>

* format

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>
strega-nil added a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
@strega-nil
prepare for new release: 2021-04-15 (microsoft#61)
96ec678 
The following PRs are included:

* hopefully fix crash in constraints (microsoft#60)
* [vcpkg] allow --version to check the version (microsoft#50)
* Remove baseline warning (microsoft#27)
* [git] always pass autocrlf=false (microsoft#58)
* ignore QtCreator CMake project files (microsoft#54)
* ignore .DS_store files (microsoft#53)
* [vcpkg] x-add-version now also checks if the manifest file is properly formatted (microsoft#43)
* hopefully fix ci issue microsoft#16773 (microsoft#34)
* Add docs to set VCPKG_ROOT to run tests (microsoft#45)
* [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (microsoft#44)
* add clang-format version to format-cxxcode (microsoft#41)
* [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (microsoft#40)
* [supports] Add `native` identifier expression and x-check-support command (microsoft#29)
* [metrics] Split reporting of installs into name:triplet (microsoft#39)
* [vcpkg] Improve error when accessing missing feature (microsoft#38)
* [vcpkg] Allow shallow git registries (microsoft#37)
* Disable git autocrlf when archiving tree (microsoft#36)
* Use only named packages from extra registries (microsoft#35)
* [registries] add metrics (microsoft#30)
* Add vcpkg policy cmake helper port support (microsoft#17)
* [osx] add support for rosetta (microsoft#23)
* don't build tls12-download unless it's needed (microsoft#33)
* Add new telemetry points for versioning (microsoft#21)
* add cmake_minimum_required to vcpkg_tags (microsoft#25)
* [x-add-versions] Perform atomic replacement of versioning files (microsoft#28)
* [tools] support gsutil (microsoft#19)
* add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26)
* Add finite timeout on CURL metrics endpoint. (microsoft#22)
* fix UB in make_error_code(utf8_errc) (microsoft#18)
@NancyLi1013
Copy link
Contributor

Seems microsoft/vcpkg-tool#34 and microsoft/vcpkg-tool#72 have solved this issue. Also the changes have been merged to vcpkg master branch. So closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@strega-nil @autoantwort @NancyLi1013 @JackBoosY