Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SFML 2.4.0 and Sery 1.0.0 support #40

Closed
wants to merge 2 commits into from
Closed

Added SFML 2.4.0 and Sery 1.0.0 support #40

wants to merge 2 commits into from

Conversation

Telokis
Copy link
Contributor

@Telokis Telokis commented Sep 20, 2016

No description provided.

@msftclas
Copy link

Hi @Ninetainedo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@Ninetainedo, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Sep 20, 2016

sery looks great, I'd be happy to pull that in via a separate request.

Looking at sfml's build output, I notice it has a bunch of extra lib files:

│   │
│   └───lib
│       │   flac.lib
│       │   freetype.lib
│       │   jpeg.lib
│       │   ogg.lib
│       │   openal32.lib
│       │   sfml-audio-d.lib
│       │   sfml-graphics-d.lib
│       │   sfml-main-d.lib
│       │   sfml-network-d.lib
│       │   sfml-system-d.lib
│       │   sfml-window-d.lib
│       │   vorbis.lib
│       │   vorbisenc.lib
│       │   vorbisfile.lib

I suspect it's building its own copies of flac, freetype, etc and statically linking them in. We don't want libraries to build private copies of libs -- they need to use the other packages so updates correctly apply system-wide.

@Telokis
Copy link
Contributor Author

Telokis commented Sep 20, 2016

I made #46 for Sery.
Regarding SFML, what would be the best solution ?
A dependency system inside the portfile ? Something similar to what is done with Cocos2d ?

@ras0219-msft
Copy link
Contributor

Yes, the CONTROL file needs to list out all the dependencies and the portfile.cmake needs to supply whatever CMake arguments are needed to coax SFML to build against the already-existing libraries.

This will probably require patching. See:
https://github.com/SFML/SFML/blob/master/CMakeLists.txt#L301
https://github.com/SFML/SFML/blob/master/src/SFML/CMakeLists.txt#L17
https://github.com/SFML/SFML/blob/master/src/SFML/Graphics/CMakeLists.txt#L93
etc.

I think the best way to figure out what needs to be fixed may be to completely delete the extlibs\ folder after extracting the source but before running vcpkg_cmake_configure. Then, CMake and cl.exe should guide us directly to all the issues.

@Telokis
Copy link
Contributor Author

Telokis commented Sep 21, 2016

From the CMakeLists, it seems that SFML doesn't have a possible workaround to allow users to compile with the libraries they already have.
That could be an issue for others libraries as well. (Thinking of Ogre #14 and its ton of dependencies right now)

Deleting extlibs before configuring would probably make vcpkg_cmake_configure error.

@Telokis
Copy link
Contributor Author

Telokis commented Sep 21, 2016

Alright, my last comment is outdated now that I've seen how opencv ports is made.
I will try to dig through it and let everyone know about my progress here.

@Telokis
Copy link
Contributor Author

Telokis commented Sep 22, 2016

I'm closing this pull request for now. I'll open an issue to keep track of my progress.

@Telokis Telokis closed this Sep 22, 2016
bartholmberg pushed a commit to bartholmberg/vcpkg that referenced this pull request Feb 12, 2021
bartholmberg pushed a commit to bartholmberg/vcpkg that referenced this pull request Feb 12, 2021
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
The following PRs are included:

* hopefully fix crash in constraints (microsoft#60)
* [vcpkg] allow --version to check the version (microsoft#50)
* Remove baseline warning (microsoft#27)
* [git] always pass autocrlf=false (microsoft#58)
* ignore QtCreator CMake project files (microsoft#54)
* ignore .DS_store files (microsoft#53)
* [vcpkg] x-add-version now also checks if the manifest file is properly formatted (microsoft#43)
* hopefully fix ci issue microsoft#16773 (microsoft#34)
* Add docs to set VCPKG_ROOT to run tests (microsoft#45)
* [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (microsoft#44)
* add clang-format version to format-cxxcode (microsoft#41)
* [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (microsoft#40)
* [supports] Add `native` identifier expression and x-check-support command (microsoft#29)
* [metrics] Split reporting of installs into name:triplet (microsoft#39)
* [vcpkg] Improve error when accessing missing feature (microsoft#38)
* [vcpkg] Allow shallow git registries (microsoft#37)
* Disable git autocrlf when archiving tree (microsoft#36)
* Use only named packages from extra registries (microsoft#35)
* [registries] add metrics (microsoft#30)
* Add vcpkg policy cmake helper port support (microsoft#17)
* [osx] add support for rosetta (microsoft#23)
* don't build tls12-download unless it's needed (microsoft#33)
* Add new telemetry points for versioning (microsoft#21)
* add cmake_minimum_required to vcpkg_tags (microsoft#25)
* [x-add-versions] Perform atomic replacement of versioning files (microsoft#28)
* [tools] support gsutil (microsoft#19)
* add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26)
* Add finite timeout on CURL metrics endpoint. (microsoft#22)
* fix UB in make_error_code(utf8_errc) (microsoft#18)
JoergAtGithub pushed a commit to JoergAtGithub/vcpkg that referenced this pull request Jul 2, 2022
dempo93 pushed a commit to dempo93/vcpkg that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants