-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SFML 2.4.0 and Sery 1.0.0 support #40
Conversation
Hi @Ninetainedo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@Ninetainedo, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Looking at
I suspect it's building its own copies of |
Yes, the This will probably require patching. See: I think the best way to figure out what needs to be fixed may be to completely delete the |
From the CMakeLists, it seems that SFML doesn't have a possible workaround to allow users to compile with the libraries they already have. Deleting extlibs before configuring would probably make |
Alright, my last comment is outdated now that I've seen how opencv ports is made. |
I'm closing this pull request for now. I'll open an issue to keep track of my progress. |
The following PRs are included: * hopefully fix crash in constraints (microsoft#60) * [vcpkg] allow --version to check the version (microsoft#50) * Remove baseline warning (microsoft#27) * [git] always pass autocrlf=false (microsoft#58) * ignore QtCreator CMake project files (microsoft#54) * ignore .DS_store files (microsoft#53) * [vcpkg] x-add-version now also checks if the manifest file is properly formatted (microsoft#43) * hopefully fix ci issue microsoft#16773 (microsoft#34) * Add docs to set VCPKG_ROOT to run tests (microsoft#45) * [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (microsoft#44) * add clang-format version to format-cxxcode (microsoft#41) * [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (microsoft#40) * [supports] Add `native` identifier expression and x-check-support command (microsoft#29) * [metrics] Split reporting of installs into name:triplet (microsoft#39) * [vcpkg] Improve error when accessing missing feature (microsoft#38) * [vcpkg] Allow shallow git registries (microsoft#37) * Disable git autocrlf when archiving tree (microsoft#36) * Use only named packages from extra registries (microsoft#35) * [registries] add metrics (microsoft#30) * Add vcpkg policy cmake helper port support (microsoft#17) * [osx] add support for rosetta (microsoft#23) * don't build tls12-download unless it's needed (microsoft#33) * Add new telemetry points for versioning (microsoft#21) * add cmake_minimum_required to vcpkg_tags (microsoft#25) * [x-add-versions] Perform atomic replacement of versioning files (microsoft#28) * [tools] support gsutil (microsoft#19) * add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26) * Add finite timeout on CURL metrics endpoint. (microsoft#22) * fix UB in make_error_code(utf8_errc) (microsoft#18)
Devendor fdk-aac
No description provided.