Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New port for mailio. #16696

Merged
merged 8 commits into from
Mar 19, 2021
Merged

New port for mailio. #16696

merged 8 commits into from
Mar 19, 2021

Conversation

karastojko
Copy link
Contributor

Describe the pull request

@autoantwort
Copy link
Contributor

You have to format your vcpkg.json file with ./vcpkg format-manifest ports/mailio/vcpkg.json. If you have committed this, you have to run ./vcpkg x-add-version mailio

@JackBoosY JackBoosY added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Mar 15, 2021
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please run ./vcpkg format-manifest --all first,
  2. then run ./vcpkg x-add-version --all and commit changes.

@JackBoosY
Copy link
Contributor

Starting package 263/274: mailio:x64-windows-static
Building package mailio[core]:x64-windows-static...
-- Downloading https://github.com/karastojko/mailio/archive/1872f29d88a52f06cd96b611673b2e46c6b9832b.tar.gz -> karastojko-mailio-1872f29d88a52f06cd96b611673b2e46c6b9832b.tar.gz...
-- Extracting source D:/downloads/karastojko-mailio-1872f29d88a52f06cd96b611673b2e46c6b9832b.tar.gz
-- Using source at D:/buildtrees/mailio/src/46c6b9832b-9aa8aa669f.clean
-- Configuring x64-windows-static
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
-- Installing: D:/packages/mailio_x64-windows-static/share/mailio/copyright
-- Performing post-build validation
DLLs should not be present in a static build, but the following DLLs were found:

    D:/packages/mailio_x64-windows-static/bin/mailio.dll
    D:/packages/mailio_x64-windows-static/debug/bin/mailio.dll

It seems that BUILD_SHARED_LIBS is not used in the internal cmake code.

@JackBoosY
Copy link
Contributor

I will help you to solve it tomorrow.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 17, 2021
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the version is changed to 0.20.0. Note that you will need to undo the changes to versions/ (git checkout upstream/master -- versions) and re-run vcpkg x-add-version mailio.

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Mar 18, 2021
JackBoosY and others added 2 commits March 18, 2021 10:10
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 18, 2021
@JackBoosY JackBoosY requested a review from ras0219-msft March 18, 2021 02:58
@karastojko
Copy link
Contributor Author

Tag renamed to 0.20.0 to follow the convention.

@ras0219-msft ras0219-msft merged commit d31eced into microsoft:master Mar 19, 2021
@ras0219-msft
Copy link
Contributor

Awesome, thanks for the great library and PR :)

@autoantwort
Copy link
Contributor

autoantwort commented Mar 19, 2021

This port is failing in the pipeline for windows uwp, as you can see here

@kotori2
Copy link
Contributor

kotori2 commented Jan 6, 2022

Any idea on how to link this library? Simply use target_link_libraries(${PROJECT_NAME} mailio) won't work and find_package won't work as well...

@karastojko
Copy link
Contributor Author

karastojko commented Jan 6, 2022

Any idea on how to link this library? Simply use target_link_libraries(${PROJECT_NAME} mailio) won't work and find_package won't work as well...

@kotori2
This works for me:

include_directories(${CMAKE_SOURCE_DIR}/libs/mailio/include)
find_library(MAILIO_LIB mailio HINTS ${CMAKE_SOURCE_DIR}/libs/mailio/build)
add_executable(${PROJ} ${PROJSRC} ${PROJINC})
target_link_libraries(${PROJ} ${Boost_LIBRARIES} Threads::Threads ${OPENSSL_LIBRARIES} ${MAILIO_LIB})

where PROJ, PROJSRC, PROJINC is another project that uses mailio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] <mailio>
5 participants