[aubio] broken build feature, it always build without the dependencies

[mhandb]

Host Environment

• OS: Windows
• Compiler: MSVC 19.28.29913

To Reproduce
Steps to reproduce the behavior:

• ./vcpkg install aubio
• Build an app that uses the new_aubio_source function
• It will fails with this error message:

source: failed creating with %s at %dHz with hop size %d"
" (no source built-in)

Failure logs

[2/86] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.299\bin\Hostx64\x64\cl.exe -DHAVE_C99_VARARGS_MACROS=1 -DHAVE_ERRNO_H=1 -DHAVE_LIMITS_H=1 -DHAVE_MATH_H=1 -DHAVE_STDARG_H=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -D_CRT_SECURE_NO_WARNINGS=1 -IC:\dev\repos\GSDK\gsdk\gsdk\gsdk-test\vcpkg\buildtrees\aubio\src\0.4.9-f1b891adc9.clean\src -I. -IC:\dev\repos\GSDK\gsdk\gsdk\gsdk-test\vcpkg_installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /MP  /MD /O2 /Oi /Gy /DNDEBUG /Z7 /showIncludes /FoCMakeFiles\aubio.dir\src\io\source.c.obj /FdCMakeFiles\aubio.dir\aubio.pdb /FS -c C:\dev\repos\GSDK\gsdk\gsdk\gsdk-test\vcpkg\buildtrees\aubio\src\0.4.9-f1b891adc9.clean\src\io\source.c

You can see in the log that it does not have the -DHAVE_LIBAV=1 flag for instance.

Additional context
This had been broken with this pull request : #16051
It added some options in the port file:

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
    FEATURES
    tools WITH_DEPENDENCIES
    tools HAVE_SNDFILE
    tools HAVE_WAVWRITE
    tools HAVE_WAVREAD
    tools HAVE_LIBAV
    tools HAVE_SWRESAMPLE
)

But most of them are not used in the CmakeLists.txt to forward the option with add_definitions()
I am not sure that all these HAV_XXX are required in the port file. WITH_DEPENDENCIES isn't enough ?
Adding this in the CMakeLists.txt fixes the issue on my side:

...
if(WITH_DEPENDENCIES)
    add_definitions(-DHAVE_SNDFILE=1)
    add_definitions(-DHAVE_WAVWRITE=1)
    add_definitions(-DHAVE_WAVREAD=1)
    add_definitions(-DHAVE_LIBAV=1)
    add_definitions(-DHAVE_SWRESAMPLE=1)
...

[autoantwort]

Hm that was that what I was using, but the maintainers said I shouldn't (see here) 😕

[mhandb]

Indeed, but the definitions are not forwarded to the compiler, I can see them in the configuration log only.

[PhoebeHui]

@mhandb, thanks for reporting this issue! I have submitted a PR to fix this issue.

[mhandb]

@PhoebeHui Any update on this issue ?