Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aubio] allow to build without dependencies #16051

Merged
merged 8 commits into from
Mar 25, 2021
Merged

[aubio] allow to build without dependencies #16051

merged 8 commits into from
Mar 25, 2021

Conversation

autoantwort
Copy link
Contributor

Fixes #15966

Can now be used on mac and linux

@ghost
Copy link

ghost commented Feb 5, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@NancyLi1013 NancyLi1013 self-assigned this Feb 5, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 5, 2021
@autoantwort autoantwort marked this pull request as ready for review February 5, 2021 01:57
NancyLi1013
NancyLi1013 suggested changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to use vcpkg_check_features() to handle the feature tools in port.cmake.

ports/aubio/CMakeLists.txt Outdated Show resolved Hide resolved
ports/aubio/CMakeLists.txt Show resolved Hide resolved
ports/aubio/CMakeLists.txt Outdated Show resolved Hide resolved
ports/aubio/CMakeLists.txt Outdated Show resolved Hide resolved
ports/aubio/CMakeLists.txt Outdated Show resolved Hide resolved
ports/aubio/CMakeLists.txt Outdated Show resolved Hide resolved
NancyLi1013
NancyLi1013 suggested changes Feb 7, 2021
View reviewed changes
ports/aubio/portfile.cmake Show resolved Hide resolved
ports/aubio/vcpkg.json Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

The failures on x64-linux:

CMake Error at /mnt/vcpkg-ci/installed/x64-linux/share/ffmpeg/vcpkg-cmake-wrapper.cmake:4 (_find_package):
  By not providing "FindFFmpeg.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "FFmpeg", but
  CMake did not find one.

  Could not find a package configuration file provided by "FFmpeg" with any
  of the following names:

    FFmpegConfig.cmake
    ffmpeg-config.cmake

  Add the installation prefix of "FFmpeg" to CMAKE_PREFIX_PATH or set
  "FFmpeg_DIR" to a directory containing one of the above files.  If "FFmpeg"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:604 (include)
  CMakeLists.txt:36 (find_package)

You can get the log here.

@autoantwort
Copy link
Contributor Author

You can get the log here.

Thanks! Works now everywhere.

autoantwort and others added 2 commits February 14, 2021 17:38
@autoantwort
Make it possible to build aubio without dependencies
9c82c5c
@autoantwort @NancyLi1013
Update ports/aubio/portfile.cmake
81ca33d 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@autoantwort
Copy link
Contributor Author

Now also on mingw. I don't now why it shows that there are Changes requested, there are no.

This was referenced Feb 15, 2021
Closed
Closed
@JackBoosY
Copy link
Contributor

Needs to test build core only.

@NancyLi1013
Copy link
Contributor

aubio[core] has been passed with the following triplets:

  • x86-windows
  • x64-windows-static
  • x64-osx

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Feb 19, 2021
@autoantwort
Copy link
Contributor Author

I have tested aubio[core] on x64-linux also. Is there anything that prevents merging?

@JackBoosY
Copy link
Contributor

@autoantwort Nope, waiting for merge.

@autoantwort
Copy link
Contributor Author

@autoantwort Nope, waiting for merge.

@ras0219-msft

@NancyLi1013
Copy link
Contributor

@ras0219-msft Could you please help review and merge this PR?

@vicroms vicroms self-assigned this Mar 23, 2021
vicroms
vicroms reviewed Mar 23, 2021
View reviewed changes
ports/aubio/CMakeLists.txt Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 23, 2021
autoantwort and others added 2 commits March 23, 2021 13:14
@autoantwort @JackBoosY
Update ports/aubio/portfile.cmake
ef8aa7a 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@autoantwort
add version files
0fa462d
JackBoosY
JackBoosY suggested changes Mar 24, 2021
View reviewed changes
ports/aubio/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY requested a review from vicroms March 25, 2021 00:50
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 25, 2021
@vicroms vicroms merged commit dc8f5b6 into microsoft:master Mar 25, 2021
@mhandb mhandb mentioned this pull request Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@vicroms vicroms Awaiting requested review from vicroms

Assignees

@vicroms vicroms

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aubio build failure
4 participants
@autoantwort @NancyLi1013 @JackBoosY @vicroms