[aubio] Fix definitions issues when build with dependencies

[PhoebeHui]

Fixes #17342

Move these definitions to CMakeLists.txt instead, they are used as compiler options, not a cmake variable, so it doesn't work when use vcpkg_check_features functions.

    tools HAVE_SNDFILE
    tools HAVE_WAVWRITE
    tools HAVE_WAVREAD
    tools HAVE_LIBAV
    tools HAVE_SWRESAMPLE

[autoantwort]

Maybe mark the feature as windows only. It never worked before on linux and mac.

[PhoebeHui]

@autoantwort, it due to the link errors from dependency.

Failures on linux and osx platform.

load_abc.cpp:(.text+0x2837): undefined reference to `operator new[](unsigned long)'
load_abc.cpp:(.text+0x2877): undefined reference to `operator new[](unsigned long)'
load_abc.cpp:(.text+0x2936): undefined reference to `operator delete[](void*)'
load_abc.cpp:(.text+0x293e): undefined reference to `operator delete[](void*)'
/mnt/vcpkg-ci/installed/x64-linux/lib/libx265.a(api.cpp.o): In function `x265_encoder_open_192':
api.cpp:(.text+0x24cd): undefined reference to `operator new(unsigned long)'
api.cpp:(.text+0x2758): undefined reference to `operator delete(void*)'
/mnt/vcpkg-ci/installed/x64-linux/lib/libx265.a(api.cpp.o): In function `x265_encoder_close':
oad_pat.cpp:(.text+0x6fed): undefined reference to `operator new(unsigned long)'
load_pat.cpp:(.text+0x741e): undefined reference to `operator new(unsigned long)'
/home/phoebe/Hui/vcpkg/installed/x64-linux/lib/libmodplug.a(load_ult.cpp.o): In function `CSoundFile::ReadUlt(unsigned char const*, unsigned int)':
load_ult.cpp:(.text+0xaf5): undefined reference to `operator new[](unsigned long)'
/home/phoebe/Hui/vcpkg/installed/x64-linux/lib/libmodplug.a(load_xm.cpp.o): In function `CSoundFile::ReadXM(unsigned char const*, unsigned int)':
load_xm.cpp:(.text+0x649): undefined reference to `operator new(unsigned long)'
load_xm.cpp:(.text+0x182a): undefined reference to `operator new[](unsigned long)'
load_xm.cpp:(.text+0x188e): undefined reference to `operator new[](unsigned long)'
/home/phoebe/Hui/vcpkg/installed/x64-linux/lib/libsnappy.a(snappy.cc.o): In function `snappy::internal::WorkingMemory::WorkingMemory(unsigned long)':
snappy.cc:(.text+0x122): undefined reference to `operator new(unsigned long)'
/home/phoebe/Hui/vcpkg/installed/x64-linux/lib/libsnappy.a(snappy.cc.o): 

[strega-nil-ms]

Marking requires:author-response for @ras0219's comments

[PhoebeHui]

PR #17985 would address ffmpeg dependency issue, I would revert ffmpeg changes, and rerun this PR after that PR merged.

[mcmtroffaes]

I'm so sorry, it seems my suggestion tripped CI.

I just reproduced the failure on x64-linux. Build works fine with ffmpeg[core,avcodec,avformat,swresample] but not with ffmpeg[all-nonfree]. It seems to be related to a missing linker flag for one of the dependencies. However, I've confirmed that #17985 fixes the linking error (at least here locally for me, after merging that branch into the branch of this PR).

[PhoebeHui]

Thanks @mcmtroffaes for testing the changes, I also confirmed that PR #17985 fixes the failures, I will rerun the Ci testing after the PR merged.

[PhoebeHui]

#17985 has been merged, and it passed in CI testing after rerun.

[PhoebeHui]

@strega-nil-ms, could you help merge this PR?

[strega-nil-ms]

Cool, thanks y'all!